On Thursday 24 January 2008, laurent FANIS wrote: > First off, i am not trying to push these patches, i was asked on IRC > to post them with some comments. > I did so.
ok ... just need to make sure the stupid BSD mentality doesnt infect you like
so many other BSD devs. keeping local changes in BSD cvs just screws
everyone long term.
> On Jan 23, 2008 7:45 AM, Mike Frysinger <[EMAIL PROTECTED]> wrote:
> > On Wednesday 23 January 2008, laurent FANIS wrote:
> > > --- configure.in.orig Wed Dec 5 22:13:29 2007
> > > +++ configure.in Wed Dec 5 22:13:42 2007
> > > @@ -31,7 +31,7 @@ AC_SUBST(version_info)
> > >
> > > AC_FUNC_ALLOCA
> > >
> > > -MODULE_ARCH="$host_os-$host_cpu"
> > > +MODULE_ARCH=""
> > > AC_SUBST(MODULE_ARCH)
> > > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
> >
> > ugh, this cant possibly be correct. can you explain what you're trying
> > to fix. same goes for all the configure scripts you modified like this.
>
> This is to be able to update cleanly the packages from one release to
> another, this is OpenBSD specific.
right, because the bsd folks insist on inserting the version into the host_os
field of their tuple. i'd be inclined to say that having multiple dirs
across bsd versions is actually correct ...
> > > --- src/lib/include/evas_common.h.orig Fri Dec 7 10:34:46 2007
> > > +++ src/lib/include/evas_common.h Fri Dec 7 10:34:59 2007
> > > @@ -46,6 +46,7 @@
> > > #include <stdio.h>
> > > #include <stdlib.h>
> > > #include <unistd.h>
> > > +#include <stdint.h>
> > > #include <string.h>
> > > #include <signal.h>
> > > #include <setjmp.h>
> >
> > stdint.h should be everywhere ;)
>
> It wasn't here and the compiler choked.
*how* did it choke
> > > In E:
> > > --- src/bin/Makefile.am.orig Fri Nov 9 16:20:53 2007
> > > +++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007
> > > @@ -345,7 +345,7 @@ e_xinerama.c
> > >
> > > enlightenment_init_LDFLAGS = @e_libs@
> > >
> > > -setuid_root_mode = a=rx,u+xs
> > > +setuid_root_mode = a=rx,u+x
> > > install-exec-hook:
> > > @chmod $(setuid_root_mode)
> > > $(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true
> >
> > clearly this is not correct.
>
> In the port system we do not install anything with setuid root. If the
> user wants it then the user has to manually update it.
then leave the hack in the port build system. it's trivial to run:
make setuid_root_mode=whatever-you-want
> > > --- src/bin/e_fm.c.orig Wed Nov 7 11:45:43 2007
> > > +++ src/bin/e_fm.c Fri Dec 7 15:44:09 2007
> > > @@ -104,7 +104,7 @@ struct _E_Fm2_Smart_Data
> > > E_Drop_Handler *drop_handler;
> > > E_Fm2_Icon *drop_icon;
> > > E_Fm2_Mount *mount;
> > > - char drop_after;
> > > + signed char drop_after;
> > > unsigned char drop_show : 1;
> > > unsigned char drop_in_show : 1;
> > > unsigned char drop_all : 1;
> >
> > either everything should be "char" or not ... inserting "signed" here
> > without an explanation as to why doesnt seem like a good idea.
>
> This fixes macppc.
please elaborate
> > > @@ -3214,7 +3214,7 @@ _e_fm2_uri_parse(const char *val)
> > > p = val + 7;
> > > if (*p != '/')
> > > {
> > > - for (i = 0; *p != '/' && *p != '\0' && i <
> > > _POSIX_HOST_NAME_MAX; p++, i++)
> > > + for (i = 0; *p != '/' && *p != '\0' && i < MAXHOSTNAMELEN; p++,
> > > i++) hostname[i] = *p;
> > > }
> > > hostname[i] = '\0';
> > > @@ -3247,9 +3247,9 @@ _e_fm2_uri_path_list_get(Evas_List *uri_list)
> > > {
> > > E_Fm2_Uri *uri;
> > > Evas_List *l, *path_list = NULL;
> > > - char current_hostname[_POSIX_HOST_NAME_MAX];
> > > + char current_hostname[MAXHOSTNAMELEN];
> >
> > move this to autotools as a build time test as this ugly churn of defines
> > will simply break some systems while "fixing" others.
> >
> > > - if (gethostname(current_hostname, _POSIX_HOST_NAME_MAX) == -1)
> > > + if (gethostname(current_hostname, MAXHOSTNAMELEN) == -1)
> >
> > sizeof(current_hostname) should be used instead
>
> Again i am not pushing these patches. This is OpenBSD specific.
OpenBSD is probably broken then. POSIX requires _POSIX_HOST_NAME_MAX to be
defined in limits.h.
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
