Nathan Ingersoll wrote: > On Wed, May 7, 2008 at 8:27 AM, dan sinclair <[EMAIL PROTECTED]> wrote: >> We'll have to wait to see if anyone complains. The problem is, we can't >> tell if issue is failed parsing or non-existing file. We may need to put >> a check in there for non-existant file. But, I don't think we should be >> pretending everything is good if the file fails to parse. >> >> dan > > If this does end up breaking things, it would be a good idea to add a > comment in that code block describing the scenario, and adding a test > case to catch any future regression.
In efreet_desktop_read, the result from efreet_ini_new isn't checked, so it will break. And in efreet_desktop_save efreet_ini_new is used to create a new ini struct regardless whether a file exists. Sebastian ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
