On Wed, Sep 3, 2008 at 11:45 AM, Dave Andreoli <[EMAIL PROTECTED]> wrote:
> ----- "Carsten Haitzler (The Rasterman)" <[EMAIL PROTECTED]> ha scritto:
>> On Wed, 3 Sep 2008 02:28:06 +0200 (CEST) Dave Andreoli
>> <[EMAIL PROTECTED]>
>> babbled:
>>
>> >
>> > ----- "Carsten Haitzler (The Rasterman)" <[EMAIL PROTECTED]> ha
>> scritto:
>> >
>> > > On Tue, 2 Sep 2008 22:16:50 +0200 (CEST) Dave Andreoli
>> > > <[EMAIL PROTECTED]>
>> > > babbled:
>> > >
>> > > >
>> > > > ----- "Cedric BAIL" <[EMAIL PROTECTED]> ha scritto:
>> > > >
>> > > > > On Thu, Aug 21, 2008 at 3:47 PM, Joerg Sonnenberger
>> > > > > <[EMAIL PROTECTED]> wrote:
>> > > > > > On Thu, Aug 21, 2008 at 11:38:32AM +0200, Cedric BAIL
>> wrote:
>> > > > > >> Ok, just testing it and reviewing it. Could you tell me
>> why
>> > > you
>> > > > > did
>> > > > > >> change this code, doesn't look like it's related to the
>> other
>> > > > > change.
>> > > > > >
>> > > > > > I have no idea where that change comes from. I suspect some
>> > > merge
>> > > > > > failure from cvs.
>> > > > > >
>> > > > > >> > Do you get timeouts from the test-suite as well?
>> > > > > >>
>> > > > > >> We have currently to test that fail :
>> > > > > >> Eet Data Encoding/Decoding:eet_test_data_type_dump_undump
>> > > > > >> Eet File:eet_file_data_dump_test
>> > > > > >>
>> > > > > >> due to a bug related to the handle of EET_G_UNKNOWN in
>> > > > > >> _eet_data_dump_encode. But other test should work just
>> fine.
>> > > > > >>
>> > > > > >> I did just run the tests with the new patch, and I am
>> still
>> > > > > >> experiencing failure :
>> > > > > >>
>> > > > > >> eet_suite.c:947:F:Eet Image:eet_image:0: Failure 'result ==
>> 0'
>> > > > > occured
>> > > > > >> eet_suite.c:1161:F:Eet Image:eet_small_image:0: Failure
>> > > 'data[0] !=
>> > > > > IM0' occured
>> > > > > >
>> > > > > > I get a timeout for this test as well. Which is why I ask.
>> > > > >
>> > > > > Ok, I fixed your patch and commited it. It should work fine,
>> but
>> > > if
>> > > > > not please report any failure regarding eet and compressed
>> image
>> > > to
>> > > > > me.
>> > > >
>> > > > Hi... some work for you :P
>> > > >
>> > > > The editor cannot import jpg images anymore, in my tests
>> > > > edje_cc segv when you use a jpg image and set it LOSSY.
>> > > >
>> > > > You can try any edc that use jpg with LOSSY like this:
>> > > > --------------------------------------------------------
>> > > > images {
>> > > > image: "mem.jpg" LOSSY 90;
>> > > > }
>> > > > collections {
>> > > > group {
>> > > > name: "icon";
>> > > > parts {
>> > > > part {
>> > > > name: "image";
>> > > > type: IMAGE;
>> > > > description {
>> > > > state: "default" 0.00;
>> > > > image {
>> > > > normal: "mem.jpg";
>> > > > }
>> > > > }
>> > > > }
>> > > > }
>> > > > }
>> > > > }
>> > > > --------------------------------------------------------
>> > > > This is the simplest test case I can provide. It segv when you
>> > > compile it,
>> > > > break in eet_image.c on line 705
>> > > >
>> > > >
>> > > > The editor in fact import all the images as LOSSY 100, and now
>> > > > segv when loading jpg. I have tested with previous revision and
>> > > works well.
>> > > >
>> > > > Let me know if you need more info ;)
>> > > >
>> > > > Dave
>> > >
>> > > just tried:
>> > >
>> > > images {
>> > > image: "vgrad_dark.png" COMP; /* the encoding method is
>> > > "COMP". this
>> > > * is lossless, but
>> compressed
>> > > */
>> > > image: "grill_dark_tiny_pattern.png" LOSSY 90;
>> > >
>> > > ...
>> > >
>> > > no segv. :/
>> >
>> > 'cause you are using a png. The problem occur only with jpg...
>> > ...as the mail subject say ;)
>>
>> source format shouldnt matter.. and it works for me:
>
> The segv is in the function eet_data_image_jpeg_convert()...
> strange that works for you :/
I found the source of the problem, jpeg_write_scanlines could fail in
some case when you are not dumping to a FILE*. So it should depend on
the file you are compressing too. I will shortly commit the fixed
version and every thing should work fine this time :-)
--
Cedric BAIL
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
