On Fri, Feb 27, 2009 at 9:03 PM, Gustavo Sverzut Barbieri
<barbi...@profusion.mobi> wrote:
> Fix your /etc/mime.types and have your files to be recognized as
> text/something or attachments will be stripped
I did the fix. Resending. ;-)
>
>
> On 2/27/09, Gustavo F. Padovan <p...@profusion.mobi> wrote:
> > Hi,
> >
> > Some simple fixes to emotion. :-)
> >
> > --
> > Gustavo F. Padovan
> > http://profusion.mobi embedded systems
> >
>
> --
> Sent from my mobile device
>
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
--
Gustavo F. Padovan
http://profusion.mobi embedded systems
From 42854ab461e176afe4aaadb19db7aea3161ea0a5 Mon Sep 17 00:00:00 2001
From: Gustavo F. Padovan <p...@profusion.mobi>
Date: Fri, 27 Feb 2009 17:24:03 -0300
Subject: [PATCH 1/3] Optimize if comparison
---
src/lib/emotion_smart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/emotion_smart.c b/src/lib/emotion_smart.c
index 789dc8b..79208fe 100644
--- a/src/lib/emotion_smart.c
+++ b/src/lib/emotion_smart.c
@@ -277,7 +277,7 @@ emotion_object_play_set(Evas_Object *obj, Evas_Bool play)
Smart_Data *sd;
E_SMART_OBJ_GET(sd, obj, E_OBJ_NAME);
- if (((play) && (sd->play)) || ((!play) && (!sd->play))) return;
+ if (play == sd->play) return;
if (!sd->module) return;
if (!sd->video) return;
sd->play = play;
--
1.6.0.6
From f6147035389693a91cf129fe907fca6ec1c43497 Mon Sep 17 00:00:00 2001
From: Gustavo F. Padovan <p...@profusion.mobi>
Date: Fri, 27 Feb 2009 17:39:34 -0300
Subject: [PATCH 2/3] error message to stderr
---
src/lib/emotion_smart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/emotion_smart.c b/src/lib/emotion_smart.c
index 79208fe..d34564c 100644
--- a/src/lib/emotion_smart.c
+++ b/src/lib/emotion_smart.c
@@ -122,7 +122,7 @@ _emotion_module_open(const char *name, Evas_Object *obj, Emotion_Video_Module **
ecore_plugin_unload(plugin);
}
else
- printf ("Unable to load module %s\n", name);
+ fprintf (stderr, "Unable to load module %s\n", name);
if (path_group)
{
--
1.6.0.6
From e2ddd35d32b2ad63a661df4687953253e85858c9 Mon Sep 17 00:00:00 2001
From: Gustavo F. Padovan <p...@profusion.mobi>
Date: Fri, 27 Feb 2009 17:40:36 -0300
Subject: [PATCH 3/3] remove if before free
---
src/lib/emotion_smart.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/lib/emotion_smart.c b/src/lib/emotion_smart.c
index d34564c..9cd682d 100644
--- a/src/lib/emotion_smart.c
+++ b/src/lib/emotion_smart.c
@@ -195,14 +195,14 @@ emotion_object_init(Evas_Object *obj, const char *module_filename)
E_SMART_OBJ_GET_RETURN(sd, obj, E_OBJ_NAME, 0);
- if (sd->file) free(sd->file);
+ free(sd->file);
sd->file = NULL;
- if (sd->title) free(sd->title);
+ free(sd->title);
sd->title = NULL;
- if (sd->progress.info) free(sd->progress.info);
+ free(sd->progress.info);
sd->progress.info = NULL;
sd->progress.stat = 0.0;
- if (sd->ref.file) free(sd->ref.file);
+ free(sd->ref.file);
sd->ref.file = NULL;
sd->ref.num = 0;
sd->spu.button_num = 0;
@@ -238,7 +238,7 @@ emotion_object_file_set(Evas_Object *obj, const char *file)
{
int w, h;
- if (sd->file) free(sd->file);
+ free(sd->file);
sd->file = strdup(file);
sd->module->file_close(sd->video);
evas_object_image_size_set(sd->obj, 0, 0);
@@ -257,7 +257,7 @@ emotion_object_file_set(Evas_Object *obj, const char *file)
sd->module->file_close(sd->video);
evas_object_image_size_set(sd->obj, 0, 0);
}
- if (sd->file) free(sd->file);
+ free(sd->file);
sd->file = NULL;
}
}
@@ -958,7 +958,7 @@ _emotion_title_set(Evas_Object *obj, char *title)
Smart_Data *sd;
E_SMART_OBJ_GET(sd, obj, E_OBJ_NAME);
- if (sd->title) free(sd->title);
+ free(sd->title);
sd->title = strdup(title);
evas_object_smart_callback_call(obj, "title_change", NULL);
}
@@ -969,7 +969,7 @@ _emotion_progress_set(Evas_Object *obj, char *info, double stat)
Smart_Data *sd;
E_SMART_OBJ_GET(sd, obj, E_OBJ_NAME);
- if (sd->progress.info) free(sd->progress.info);
+ free(sd->progress.info);
sd->progress.info = strdup(info);
sd->progress.stat = stat;
evas_object_smart_callback_call(obj, "progress_change", NULL);
@@ -981,7 +981,7 @@ _emotion_file_ref_set(Evas_Object *obj, char *file, int num)
Smart_Data *sd;
E_SMART_OBJ_GET(sd, obj, E_OBJ_NAME);
- if (sd->ref.file) free(sd->ref.file);
+ free(sd->ref.file);
sd->ref.file = strdup(file);
sd->ref.num = num;
evas_object_smart_callback_call(obj, "ref_change", NULL);
@@ -1243,10 +1243,10 @@ _smart_del(Evas_Object * obj)
if (sd->video) sd->module->file_close(sd->video);
_emotion_module_close(sd->module, sd->video);
evas_object_del(sd->obj);
- if (sd->file) free(sd->file);
+ free(sd->file);
if (sd->job) ecore_job_del(sd->job);
- if (sd->progress.info) free(sd->progress.info);
- if (sd->ref.file) free(sd->ref.file);
+ free(sd->progress.info);
+ free(sd->ref.file);
free(sd);
ecore_job_shutdown();
--
1.6.0.6
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
