These patches fix a few issues I had with epsilon:

epsilon_new_fix.diff:
in epsilon_new() tsize wasn't set, which defaults to THUMB_SIZE_CUSTOM which
would then fail if neither size nor PATH_DIR_CUSTOM gets changed.

epsilon_thumb_test_eina.diff:
ecore_file_ls() was changed to return eina_list, change epsilon_thumb_test to
use it.

I also noticed that epsilon_thumbd would not always terminate, but sometimes
just sit there eating cpu time, but I don't know what's going on with all the
ecore_ipc stuff, so can't fix it.

hendrik
Index: src/lib/Epsilon.c
===================================================================
--- src/lib/Epsilon.c	(Revision 39684)
+++ src/lib/Epsilon.c	(Arbeitskopie)
@@ -83,6 +83,7 @@
 	  result->src = eina_stringshare_add(file);
 	  result->tw = THUMB_SIZE_LARGE;
 	  result->th = THUMB_SIZE_LARGE;
+	  result->tsize = THUMB_SIZE_LARGE;
 	  result->format = EPSILON_THUMB_FDO;
 	  result->crop_x = 0.5;
 	  result->crop_y = 0.5;
Index: src/bin/epsilon_thumb_test.c
===================================================================
--- src/bin/epsilon_thumb_test.c	(Revision 39684)
+++ src/bin/epsilon_thumb_test.c	(Arbeitskopie)
@@ -1,6 +1,6 @@
 #include <Ecore.h>
-#include <Ecore_Data.h>
 #include <Ecore_File.h>
+#include <Eina.h>
 #include "Epsilon_Request.h"
 #include <stdio.h>
 #include <stdlib.h>
@@ -34,7 +34,7 @@
 int main(int argc, char** argv)
 {
 	char *file;
-	Ecore_List *files;
+	Eina_List *files, *l;
 	double start, end;
 	Epsilon_Thumb_Size thumb_size = EPSILON_THUMB_NORMAL;
 	Epsilon_Thumb_Format thumb_format = EPSILON_THUMB_FDO;
@@ -45,6 +45,7 @@
 		exit(0);
 	}
 
+	eina_list_init();
 	epsilon_request_init();
 
 	thumb_done = ecore_event_handler_add(EPSILON_EVENT_DONE, thumb_complete_cb, NULL);
@@ -62,8 +63,7 @@
 
 	start = ecore_time_get();
 
-	ecore_list_first_goto(files);
-	while ((file = ecore_list_next(files))) {
+	EINA_LIST_FOREACH(files, l, file) {
 		char *realpath;
 		char fullpath[PATH_MAX];
 
@@ -74,8 +74,9 @@
 			incomplete_thumbs++;
 		}
 		free(realpath);
+		free(file);
 	}
-	ecore_list_destroy(files);
+	eina_list_free(files);
 
 	ecore_main_loop_begin();
 
@@ -83,5 +84,6 @@
 	printf("\nEpsilon Thumb completed in %g seconds\n\n", end - start);
 
 	epsilon_request_shutdown();
+	eina_list_shutdown();
 	return 0;
 }
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to