On Sun, May 17, 2009 at 5:50 PM, Gustavo Sverzut Barbieri <[email protected]> wrote: > Hi, > > I initially disabled "everything" module build, but I had not reviewed > or tried it because I did think it was in early stages, after all it > is a GSoC project and GSoC is not even started. But warned by thomasg, > I tried and and even did a quick review of its code: it already looks > good and works nicely! congrats jeffdameth! > > It is now enabled by default and I urge users of "execbuf" to move to > this new module, just enable it and reassign your keybidings to use > the new action (Run Everything Dialog). It already do what "execbuf" > did, but will also enable you to switch to existing windows (winlist) > and open e17 settings! I really expect it to grow to provide calc and > aspell/dict that interact with clipboard soon, let's see ;-) > > Jeffdameth, after a quick review I see that you could: > - fix some error handling cases, specially in evry_show() you can > leak the input_window with grab if you fail to alloc popup and so. > - use new e_zone_useful_geometry_get() to properly center dialog > considering shelves. this is more important on devices with small > screens but big shelves, like netbooks/mids. dialogs should be > centered in the empty space (consider shelves/panel). > - some functions lack (void) and use () > - lots of trailing whitespace. > - use more eina macros, like EINA_LIST_FOREACH
I forgot about some: - use const char* for string parameters you should not modify, like buffer you give to plugins. actually add const to all parameters you should not modify, not just const char *. - cache strlen() results as much as possible, you often just modify strings in few places. - hashes allocate a *lot* of buckets by default, avoid using them for stuff with few items. If you have few options, it's better to strcmp(), if it's often >5, you can use eina_hash_string_small_new() instead. - consider improving the underlying platform, example is to search .desktops that startswith or contains some pattern, you're using globs, that can be much more slower than a simple strncmp() or strstr(). You'll notice that efreet is not that good, icon lookup is not as fast as it should be, we could use your manpower to help fixing those :-) > other than these minor stuff, it looks good already! > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: [email protected] > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
