2009/5/29 André Loureiro <loureiro.and...@gmail.com>: > Hi guys, > > I've made the bindings for epdf library, and I would like put it > in your svn repository, how can i do this? > the current repository is in gitorious.org, but I think that is not > better place.
Hi André, Before I merge your work inside SVN I need you to fix some problems with it: - release the GIL in functions that (possibly) take long, like render(). See http://svn.enlightenment.org/svn/e/trunk/BINDINGS/python/python-ecore/ecore/ecore.c_ecore.pyx (Reminds me that I need to add such to evas render as well, if you could submit a patch to improve that it would be great!) - do not use self.Xobj, use self.obj instead, so it's consistent among all efl. (for C object pointer) - consistent name of classes: epdf.Page, not epdf.EPage. - avoid creating dicts for things that do not need one, for example in EPage.text_find(), either return a tuple, or return an evas.Rect instead. - watch out memory leaks! EPage.text_find() is leaking the returned list and nodes, you need to free it. Please review the whole code in parts that returns lists and char*. - watch out NULL -> python. If any function can return NULL on char*, you need to check for that and convert to None yourself, otherwise the application will segv. Regards, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
