On Sat, Jun 6, 2009 at 7:42 PM, Peter Wehrfritz<peter.wehrfr...@web.de> wrote: > Cedric BAIL schrieb: >> On Sat, Jun 6, 2009 at 5:48 PM, Albin Tonnerre<albin.tonne...@gmail.com> >> wrote: >>> On Sat, Jun 06, 2009 at 12:12:49PM -0300, Andre Dieb wrote : >>> >>>> >>>> This patch contains my other two previous patches: >>>> >>>> - [PATCH] Fix eina mempool leak, init error handling, remove consumed >>>> TODO msg >>>> - [PATCH] Add checks to eina_module_new >>>> >>>> Also fixes the build error with --disable-magic-debug. >>>> >>> >>> I still think that when ecore_magic is disabled, it would be better to >>> use >>> functions rather than preprocessor macros for things like >>> eina_magic_string_init(). Indeed, that would avoid exporting different >>> symbols >>> depending on whether eina has magic-debug enabled or not. If you use >>> macros, an >>> application using magic debug compiled against eina without magic-debug >>> will >>> have to be recompiled to benefit from it if it gets enabled in eina at a >>> later >>> point. If you use functions, this is no longer an issue. >>> >>> Thoughts ? >>> >> >> I strongly disagree, when you disable magic debug in eina, you want to >> avoid it's cost at all. This include the call of the function call. >> And from my test, it does have a big impact to just enter an empty >> function. When we are speaking about performance, I think we can >> accept the little tradeoff of needing to recompile application using >> eina for maximum performance. >> > > Are you kidding? How often do you call this function? Maybe 20 times, even > if you call it 100 or 1000 times, I strongly doubt that you can measure a > performance difference.
No, I am not. That's why we have a way to disable magic debug in evas (evas doesn't currently use eina magic debug, but will in the futur). Without this option some of my application are loosing around 10% of their time inside this magic debug stuff. -- Cedric BAIL ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
