On Mon, 24 Aug 2009, Christopher Michael wrote:

> Christopher Michael wrote:
>> Looking through some code, I stumbled upon this which doesn't seem right:
>>
>> EAPI Evas *
>> evas_object_evas_get(const Evas_Object *obj)
>> {
>>     MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ);
>>     return NULL;
>>     MAGIC_CHECK_END();
>>     if (obj->delete_me) return 0;
>>     return obj->layer->evas;
>> }
>>
>> Shouldn't that be:
>>     if (obj->delete_me) return NULL;
>>
>> ??
>>
>> dh
>
> OR even:
>
>      MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ);
>      return 0;
>      MAGIC_CHECK_END();

to be consistent, return NULL on both. Technically, NULL is 0, like its 
name says.

Vincent

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to