2009/11/11 Carsten Haitzler <[email protected]>: > On Wed, 11 Nov 2009 18:12:12 -0200 João Paulo Rechi Vita > <[email protected]> said: > >> On Wed, Nov 11, 2009 at 5:13 PM, Vincent Torri <[email protected]> wrote: >> > >> > >> >> - static const char *extensions[] = { "avi", "mp4", "ogv", "mov", NULL >> >> }; >> >> + static const char *extensions[] = { "avi", "mp4", "ogv", "mov", "mpg", >> >> "wmv", >> > >> > mpeg ? mkv ? >> > >> >> Those are the only ones I've tested so far. I'll do more tests and >> also add a way to select which emotion backend to use in ethumb (right >> now xine is hardcoded). > > lots more in the way of extensions exist. the problem you have is if gsst or > xine have a handler for that container + codec. even then the extension can > lie. but others are indeed: > > mpeg, mkv .... and mp2, mp1, asf, 3gp, dv, flv, rmv, wmv, ... to name a few > more: > > http://www.fileinfo.com/filetypes/video > > imho - just add everything known to the list. if it works or not is a matter > of working codec + container handddling and that will vary from install to > install, version to version of codec libs as well as the file. >
I personally think the best would have ethumb to open the file and check if the file is a video, image or pdf instead of trusting file extensions to know which plugin to use. Of course this has performance implications, but compared to the cost of generating a thumbnail this shouldn't impact much. Besides that, the idea is to still maintain a fast path alternative in a separate D-Bus call (generate_fast() or something like). Anyway, I agree with adding all extensions in ethumb-emotion plugin for now, I'll cook a patch for it latter today and send for review. -- João Paulo Rechi Vita ProFUSION embedded systems [email protected] ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
