On Thu, Apr 8, 2010 at 4:37 PM, Christopher Michael <cpmicha...@comcast.net> wrote: > I noticed while looking through the code of the Modules Dialog, that we > are using "assert" in some places there. I don't think this is such a > good idea :( Do we really want the whole window manager terminating on > the off chance that the modules dialog has a problem ?
assert is not error handling, rather an assertion of an always valid situation, that when is not respected it should crash with a nice way to identify. That's why official deployment should compile with NDEBUG and the assert is removed altogether. For other cases, I'd rather go with the safety-check thing that we have in eina. It will log as critical (and allows abort-on-critical behavior) and can also be disabled at compile time, so an enhanced version :-) Just be aware to read safety check documentation before using it, the order of include matters. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
