On Fri, Jul 16, 2010 at 2:50 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
> From: ?\236?\158?\165?\237?\154?\168?\236?\152?\129
> <hyoyoung.ch...@samsung.com>
>
> I've added elm_label features. That are fontsize, color, background color and
> ellipsis (cutting text to fit widget size) features. Most of the property
> setting API is wrapping to label tag set.
>
> The rllipsis feature checks part size and cuts character to fit its size.
There are a few problems with this patch, maybe the author could fix
them? The summary is that it is not much EFL-like, or using
technologies as they should:
1. no getters for functions with setters, also add these with
"const" keywords;
2. why have a fixed rectangle swallowed as bg? It just make things
more complex! With a color class and edje signals to turn it on/off,
we could do it much better, actually we'd allow one to use an image to
simulate a rounded-corner rectangle or just border depending on the
theme. The same with tiling could be used to implement those
spell-check like highlights. I just double-checked, Edje can have
color_class PER-OBJECT and they will be independent of other instances
of that group;
3. The approach of change user-defined text internally, without
keeping that value for retrieval operations. You set a string and get
something different with elm_label_label_get() :-/
4. Functions such as _get_value_in_key_string() and
_strbuf_key_value_replace() really scares me. These are something that
should not be in Elementary, but in Evas. The whole ellipsis code
definitely should be in evas_object_textblock, exposed in Edje part
description (with a signal to change states). It could be much faster
than what was done, and used by Edje or pure-Evas.
5. coding style is a crazy mess, missing spaces, missing
parenthesis, non-usual comparisons like _is_width_over(obj) == 1...
I know we're all under time constrained schedules, but things that
people consider "core" such as label and textblock should receive a
bit of care, otherwise we'll face hard problems in future. We're
already close to hit hard brick walls doing the bidirectional
rendering, maybe time to have someone to work on this for once and for
all, removing the bottlenecks and bad usages such as the style
serialization/parse that is done by both Edje AND Evas (and now
Elementary)?
BR,
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
