Hey guys,
find attached a patch for a SEGV, when chosing an action in the acpi bindings dialog, while not having selected a binding for it first. BR, Leif
diff --git a/e/src/modules/conf_acpibindings/e_int_config_acpibindings.c b/e/src/modules/conf_acpibindings/e_int_config_acpibindings.c index 1de7524..7cdc8c2 100644 --- a/e/src/modules/conf_acpibindings/e_int_config_acpibindings.c +++ b/e/src/modules/conf_acpibindings/e_int_config_acpibindings.c @@ -285,7 +285,7 @@ _selected_binding_get(E_Config_Dialog_Data *cfdata) { E_Config_Binding_Acpi *bind; - if (!cfdata) return NULL; + if (!cfdata || !cfdata->bindex) return NULL; if (!(bind = eina_list_nth(cfdata->bindings, atoi(cfdata->bindex)))) return NULL; return bind; diff --git a/e/src/modules/conf_acpibindings/e_mod_main.c b/e/src/modules/conf_acpibindings/e_mod_main.c index 7691f11..3509d92 100644 --- a/e/src/modules/conf_acpibindings/e_mod_main.c +++ b/e/src/modules/conf_acpibindings/e_mod_main.c @@ -29,7 +29,7 @@ e_modapi_shutdown(E_Module *m) { E_Config_Dialog *cfd; - if (cfd = e_config_dialog_get("E", "advanced/acpi_bindings")) + if ((cfd = e_config_dialog_get("E", "advanced/acpi_bindings"))) e_object_del(E_OBJECT(cfd)); e_configure_registry_item_del("advanced/acpi_bindings"); e_configure_registry_category_del("advanced");
------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel