On Fri, 27 Aug 2010 00:08 +0200, Vincent Torri wrote : > > > On Thu, 26 Aug 2010, Michael Jennings wrote: > > > No, that's the whole point. Every instance that was patched needs to > > be examined and probably fixed. Reverting it doesn't accomplish > > anything either. > > that patch is NOT good, hence it should not be in. A mail showing where > the problems are, without modifying the code in svn is far way better than > committing something wrong.
I don't have any strong opinion as to whether this should be reverted or not, but I do agree with Vincent that sending the patch to the ML saying "hey, those places probably need fixing" would have been a far nicer approach. Cheers, -- Albin Tonnerre ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
