On 09/11/2010 11:25 PM, Lucas De Marchi wrote:
> On Sat, Sep 11, 2010 at 2:30 PM, Enlightenment SVN
> <no-re...@enlightenment.org> wrote:
>> Log:
>> Finally remember (in the eet settings) eve browser when we choose it.
>>
>> Author: rui
>> Date: 2010-09-11 10:30:22 -0700 (Sat, 11 Sep 2010)
>> New Revision: 52160
>>
>> Modified:
>> trunk/elmdentica/src/settings.c
>>
>> Modified: trunk/elmdentica/src/settings.c
>> ===================================================================
>> --- trunk/elmdentica/src/settings.c 2010-09-11 17:21:12 UTC (rev 52159)
>> +++ trunk/elmdentica/src/settings.c 2010-09-11 17:30:22 UTC (rev 52160)
>> @@ -922,6 +922,7 @@
>> case BROWSER_MIDORI: { settings->browser=b; break; }
>> case BROWSER_WOOSH: { settings->browser=b;
>> break; }
>> case BROWSER_DILLO: { settings->browser=b;
>> break; }
>> + case BROWSER_EVE: { settings->browser=b;
>> break; }
>
>
> I've never seem the source code of elmdentica, but this piece is
> really weird. Why not something like below?
>
> case BROWSER_MIDORI:
> case BROWSER_WOOSH:
> case BROWSER_DILLO:
> case BROWSER_EVE:
> settings->browser=b;
> break;
>
> Lucas De Marchi
LOL
I guess at the time I thought about doing different things according to
a different browser, but now it probably doesn't even makes any sense to
keep a switch statement :)
If the baby is calm enough later on, I'll clear that useless use of switch!
Rui
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
