On Fri, 08 Oct 2010 19:02:58 -0300 Raphael Kubo da Costa <k...@profusion.mobi> said:
ugh. requiring curl outside of ecore_con to pass the httpost thing in and out is wrong (tm). this needs to be wrapped. an ecore_con data struct needed. this bit of the api is unusable as it stands (imho) due to this. very good point. this needs to be fixed. ecore_con_url_time() also doesn't make me happy with time_t - i'd rather double for time (as with other bits of ecore). ecore_con_url_http_post_send(0 absolutely needs fixing to somehow provide this via ecore_con wrapped stuff. ecore_con doesnt expose curl as such and whatever implementation of http exists inside is hidden, so it shouldnt expose the curl data struct requirement here. > Hey there, > > Since the ecore_con_url API discussion season is open, I was thinking > about ecore_con_url_http_post_send: it accepts Ecore_Con_Url* and a > void*, the latter being passed to CURLOPT_HTTPPOST, which actually > requires a curl_httppost* struct constructed in an... exotic way via > curl_formadd(). > > I don't really see why a void* was chosen on the Ecore_Con_Url side: > on the one hand, this means the ecore_con_url_* family of functions do > not require curl-specific types as their arguments; on the other hand, > the API user will need to call curl_formadd manually anyway for the > function call to work. > > I'd like to know what you think of this: should we just add some note > on ecore_con_url_http_post_send's apidox and let one shoot oneself on > the foot, should we explicitly require a curl_httppost* instead of a > void* or should we add some API to construct the form data the EFL way > and then pass this to ecore_con_url_http_post_send()? > > -- > Raphael Kubo da Costa > ProFUSION embedded systems > http://profusion.mobi > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platforms. Download your free trials today! http://p.sf.net/sfu/adobe-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel