> Modified: trunk/TMP/st/elementary/src/lib/elm_thumb.c
> ===================================================================
> --- trunk/TMP/st/elementary/src/lib/elm_thumb.c 2010-10-18
> 23:19:13 UTC (rev 53587) +++
> trunk/TMP/st/elementary/src/lib/elm_thumb.c 2010-10-19
> 02:17:37 UTC (rev 53588) @@ -624,11 +624,8 @@ ELM_CHECK_WIDTYPE(obj,
> widtype); Widget_Data *wd = elm_widget_data_get(obj);
>
> - if (setting < ELM_THUMB_ANIMATION_START ||
> - setting >= ELM_THUMB_ANIMATION_LAST)
> - {
> + if (setting >= ELM_THUMB_ANIMATION_LAST)
> return;
> - }
>
> wd->anim_setting = setting;
> if (setting == ELM_THUMB_ANIMATION_LOOP)
I've seen this warning dozens of times, but I didn't think it was safe
to remove.
My understanding (C90 knowledge here) is that unfortunately
the enum may be signed or unsigned, C doesn't guarantee either unless
you have a value that can only be represented by signed or unsigned
values. (Be careful here, the enumeration _values_ are 'int', the
enumeration itself may not be).
So this means a different compiler or a different architecture (say one
that doesn't do unsigned numbers well) may generate code as signed,
meaning the entire test could now be invalidated.
I also don't know a way to shut up GCC in a sane manner, aside from
a swath of casts: which is also extremely ugly.
Regards,
nash
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
