On Wed, Oct 20, 2010 at 10:08 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
>  Fix focus in flow mode.
>
>  You only can give focus to visible objects, hidden objects are
>  unfocusable.
> Author:       tiago
> Date:         2010-10-20 05:08:42 -0700 (Wed, 20 Oct 2010)
> New Revision: 53655
>
> Modified:
>  trunk/ephoto/src/bin/ephoto_flow_browser.c trunk/ephoto/src/bin/ephoto_main.c
>
> Modified: trunk/ephoto/src/bin/ephoto_flow_browser.c
> ===================================================================
> --- trunk/ephoto/src/bin/ephoto_flow_browser.c  2010-10-20 12:08:39 UTC (rev 
> 53654)
> +++ trunk/ephoto/src/bin/ephoto_flow_browser.c  2010-10-20 12:08:42 UTC (rev 
> 53655)
> @@ -415,6 +415,7 @@
>         fb->viewer = _viewer_add(fb->orient_layout, fb->path);
>         elm_layout_content_set
>           (fb->orient_layout, "elm.swallow.content", fb->viewer);
> +        evas_object_show(fb->viewer);

wrong, wrong, wrong... I wouldn't expect this coming from you :-(
we just swallowed the damn object! it makes no sense to show it.
Actually we're forbidden to do so.


> @@ -21,8 +21,8 @@
>
>    ephoto_flow_browser_path_set(ephoto->flow_browser, NULL);
>    ephoto_slideshow_entry_set(ephoto->slideshow, NULL);
> +   elm_pager_content_promote(ephoto->pager, ephoto->thumb_browser);
>    elm_object_focus(ephoto->thumb_browser);
> -   elm_pager_content_promote(ephoto->pager, ephoto->thumb_browser);
>    _ephoto_state_set(ephoto, EPHOTO_STATE_THUMB);

order should not matter. Something ELSE is wrong there and you're just
working around it here. The promote can be delayed and postponed due
internal elm_pager internals, you should not trust it.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to