It is for synchronizing it. In fact the assert failed without this patch.
assert(sizeof(list_horizontal_mode_choices)/sizeof(list_horizontal_mode_choices[0])
== ELM_LIST_LAST + 1);
Then maybe we need a different solution, update the assert ?
2010/11/15 Daniel Juyung Seo <seojuyu...@gmail.com>
> oh sorry, I mistyped your name, Jonathan Atton.
>
>
> On Mon, Nov 15, 2010 at 3:45 PM, Daniel Juyung Seo <seojuyu...@gmail.com>
> wrote:
> > Hello, Janathan Atton (watchwolf),
> > i'm just curious about your changes.
> >
> > +static const char* list_horizontal_mode_choices[] = {"compress",
> > "scroll", "limit", "expand", NULL};
> >
> > does genlist need "expand mode"?
> > or is this just for synchronizing genlist externals with Elm_List_Mode?
> >
> > thanks.
> > Daniel Juyung Seo.
> >
> >
> > On Thu, Nov 11, 2010 at 7:44 AM, Enlightenment SVN
> > <no-re...@enlightenment.org> wrote:
> >> Log:
> >> elm : add expand in the edje external genlist
> >>
> >>
> >> Author: watchwolf
> >> Date: 2010-11-10 14:44:44 -0800 (Wed, 10 Nov 2010)
> >> New Revision: 54445
> >>
> >> Modified:
> >> trunk/TMP/st/elementary/src/edje_externals/Makefile.am
> trunk/TMP/st/elementary/src/edje_externals/elm_genlist.c
> trunk/TMP/st/elementary/src/edje_externals/modules.inc
> >>
> >> Modified: trunk/TMP/st/elementary/src/edje_externals/Makefile.am
> >> ===================================================================
> >> --- trunk/TMP/st/elementary/src/edje_externals/Makefile.am
> 2010-11-10 21:47:32 UTC (rev 54444)
> >> +++ trunk/TMP/st/elementary/src/edje_externals/Makefile.am
> 2010-11-10 22:44:44 UTC (rev 54445)
> >> @@ -52,7 +52,10 @@
> >> elm_toggle.c \
> >> elm_toolbar.c \
> >> elm_notify.c \
> >> -elm_panes.c
> >> +elm_panes.c \
> >> +elm_label.c \
> >> +elm_icon.c \
> >> +elm_scroller.c
> >>
> >> module_la_LIBADD = $(top_builddir)/src/lib/libelementary.la
> >> module_la_LDFLAGS = -no-undefined -module -avoid-version -shared -fPIC
> >>
> >> Modified: trunk/TMP/st/elementary/src/edje_externals/elm_genlist.c
> >> ===================================================================
> >> --- trunk/TMP/st/elementary/src/edje_externals/elm_genlist.c
> 2010-11-10 21:47:32 UTC (rev 54444)
> >> +++ trunk/TMP/st/elementary/src/edje_externals/elm_genlist.c
> 2010-11-10 22:44:44 UTC (rev 54445)
> >> @@ -22,7 +22,7 @@
> >> Eina_Bool v_bounce_exists:1;
> >> } Elm_Params_Genlist;
> >>
> >> -static const char* list_horizontal_mode_choices[] = {"compress",
> "scroll", "limit", NULL};
> >> +static const char* list_horizontal_mode_choices[] = {"compress",
> "scroll", "limit", "expand", NULL};
> >>
> >> static Elm_List_Mode
> >> _list_horizontal_mode_setting_get(const char *horizontal_mode_str)
> >>
> >> Modified: trunk/TMP/st/elementary/src/edje_externals/modules.inc
> >> ===================================================================
> >> --- trunk/TMP/st/elementary/src/edje_externals/modules.inc
> 2010-11-10 21:47:32 UTC (rev 54444)
> >> +++ trunk/TMP/st/elementary/src/edje_externals/modules.inc
> 2010-11-10 22:44:44 UTC (rev 54445)
> >> @@ -23,3 +23,6 @@
> >> DEFINE_TYPE(toolbar)
> >> DEFINE_TYPE(notify)
> >> DEFINE_TYPE(panes)
> >> +DEFINE_TYPE(label)
> >> +DEFINE_TYPE(icon)
> >> +DEFINE_TYPE(scroller)
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Centralized Desktop Delivery: Dell and VMware Reference Architecture
> >> Simplifying enterprise desktop deployment and management using
> >> Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
> >> client virtualization framework. Read more!
> >> http://p.sf.net/sfu/dell-eql-dev2dev
> >> _______________________________________________
> >> enlightenment-svn mailing list
> >> enlightenment-...@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >>
> >
>
>
> ------------------------------------------------------------------------------
> Centralized Desktop Delivery: Dell and VMware Reference Architecture
> Simplifying enterprise desktop deployment and management using
> Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
> client virtualization framework. Read more!
> http://p.sf.net/sfu/dell-eql-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Regards.
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
