Hi, This is Hermet
Because original elm_transit had event blocking for the objects in default,
it had two APIs - elm_transit_event_block_disabled_set,
elm_transit_event_block_disabled_get.
But the concept is modified to no-event-blocking in default when it is
contributed.
So the APIs was changed to elm_transit_event_block_set,
elm_transit_event_block_get also.
Designing the transit for the temporary effect, I think that blocking-event
mode is more used then non-blocking generally.
Additionally, a few applications are using original elm_transit already in
our platform,
I hope to re-back if it does not really necessary.
Could you please consider my proposal to re-back the concept?
I attached the small patch file.
Thanks.
Index: elm_transit.c
===================================================================
--- elm_transit.c (revision 55099)
+++ elm_transit.c (working copy)
@@ -282,6 +282,7 @@
EINA_MAGIC_SET(transit, ELM_TRANSIT_MAGIC);
elm_transit_tween_mode_set(transit, ELM_TRANSIT_TWEEN_MODE_LINEAR);
+ elm_transit_event_block_disabled_set(transit, EINA_TRUE);
transit->time.duration = duration;
@@ -531,7 +532,7 @@
* @ingroup Transit
*/
EAPI void
-elm_transit_event_block_set(Elm_Transit *transit, Eina_Bool disabled)
+elm_transit_event_block_disabled_set(Elm_Transit *transit, Eina_Bool disabled)
{
ELM_TRANSIT_CHECK_OR_RETURN(transit);
@@ -562,14 +563,14 @@
*
* @see elm_transit_event_block_set()
*
- * @param transit The Transit object
+ * @param[in] transit The Transit object
* @return EINA_TRUE, when event block is enabled. If @p transit is NULL
* EINA_FALSE is returned
*
* @ingroup Transit
*/
EAPI Eina_Bool
-elm_transit_event_block_get(const Elm_Transit *transit)
+elm_transit_event_block_disabled_get(const Elm_Transit *transit)
{
ELM_TRANSIT_CHECK_OR_RETURN(transit, EINA_FALSE);
@@ -692,8 +693,8 @@
* ELM_TRANSIT_TWEEN_MODE_DECELERATE - The animation will be slowed over time.
* ELM_TRANSIT_TWEEN_MODE_ACCELERATE - The animation will accelerate over time.
*
- * @param transit The transit object.
- * @param tween_mode The tween type.
+ * @param[in] transit The transit object.
+ * @param[in] tween_mode The tween type.
*
* @ingroup Transit
*/
@@ -710,14 +711,14 @@
*
* @note @p transit can not be NULL
*
- * @param transit The transit object.
+ * @param[in] transit The transit object.
* @return The tween type. If @p transit is NULL
* ELM_TRANSIT_TWEEN_MODE_LINEAR is returned.
*
* @ingroup Transit
*/
EAPI Elm_Transit_Tween_Mode
-elm_transit_tween_mode_get(Elm_Transit *transit)
+elm_transit_tween_mode_get(const Elm_Transit *transit)
{
ELM_TRANSIT_CHECK_OR_RETURN(transit, ELM_TRANSIT_TWEEN_MODE_LINEAR);
Index: Elementary.h.in
===================================================================
--- Elementary.h.in (revision 55099)
+++ Elementary.h.in (working copy)
@@ -2422,15 +2423,15 @@
EAPI void elm_transit_object_add(Elm_Transit *transit,
Evas_Object *obj);
EAPI void elm_transit_object_remove(Elm_Transit *transit,
Evas_Object *obj);
EAPI const Eina_List *elm_transit_objects_get(const Elm_Transit
*transit);
- EAPI void elm_transit_event_block_set(Elm_Transit
*transit, Eina_Bool disabled);
- EAPI Eina_Bool elm_transit_event_block_get(const Elm_Transit
*transit);
+ EAPI void
elm_transit_event_block_disabled_set(Elm_Transit *transit, Eina_Bool disabled);
+ EAPI Eina_Bool elm_transit_event_block_disabled_get(const
Elm_Transit *transit) EINA_ARG_NONNULL(1);
EAPI void elm_transit_del_cb_set(Elm_Transit *transit,
void (*cb)(void *data, Elm_Transit* transit), void *data);
EAPI void elm_transit_auto_reverse_set(Elm_Transit
*transit, Eina_Bool reverse);
EAPI Eina_Bool elm_transit_auto_reverse_get(Elm_Transit
*transit) EINA_ARG_NONNULL(1);
EAPI void elm_transit_repeat_times_set(Elm_Transit
*transit, int repeat);
EAPI int elm_transit_repeat_times_get(Elm_Transit
*transit);
EAPI void elm_transit_tween_mode_set(Elm_Transit
*transit, Elm_Transit_Tween_Mode tween_mode);
- EAPI Elm_Transit_Tween_Mode elm_transit_tween_mode_get(Elm_Transit
*transit) EINA_ARG_NONNULL(1);
+ EAPI Elm_Transit_Tween_Mode elm_transit_tween_mode_get(const Elm_Transit
*transit) EINA_ARG_NONNULL(1);
EAPI void *elm_transit_effect_resizing_context_new(Evas_Coord
from_w, Evas_Coord from_h, Evas_Coord to_w, Evas_Coord to_h);
EAPI void elm_transit_effect_resizing_op(void *data, Elm_Transit
*transit, double progress);
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
