On Wed, 1 Dec 2010 16:32:02 -0200 Bruno Dilly <bdi...@profusion.mobi> said:
1. because actionslider vs magnetslider really makes little to no difference in name. in fact magnetslider.. is possibly worse. magnet? what does this do? well it sliders? magnet? - it's a choice of an action to do. so it's a better name (though marginally). 2. because i sat down with the people who wrote it and are depending on it and already have a large chunk of code that depends on its name and for the sake of a "not really better name at all" have to go and inform dozens of developers within and outside of their control that they have to go change their code for what is a pretty debatable change. they have to sink many hours into these developers filing bug reports, then reading them, responding, responding to leaders questioning why they create all this work and for what good reason, etc. so a simple change of name costs dozens if not 100's of hours of effort. i have to weigh up that cost vs the benefits of a better name - will magnetslider save dozens if not 100's of hours of work in the long run - or more? will actionslider mean that upstream development is saddled with a lot more maintenance work? will it means the api is a lot more confusing and hard to use? my take on it is.. there is no appreciable difference in the names in terms of readability/memorability/typability/learnability (ie the important things for widget names - a user new to a widget set needs to learn the names of the objects he deals with and what they do and the name can help by being learnable/guessable/rememberable - but it cant be so long as to be impossible to type etc.). magnet vs action... really is little difference. as i said above - action is probably more usable, but not by much. given the cost of the change - it's better to keep as-is. > On Wed, Dec 1, 2010 at 7:54 AM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: > > Log: > > magnet->action (slider) > > Why are you changing this, Raster? > Don't you think magnetslider explains much better what this widget do > than actionslider? > > I would be glad to hear from you why are you changing the name of the > widgets to something worse, IMHO. > > > > > > > > > Author: raster > > Date: 2010-12-01 01:54:20 -0800 (Wed, 01 Dec 2010) > > New Revision: 55116 > > Trac: http://trac.enlightenment.org/e/changeset/55116 > > > > Added: > > trunk/TMP/st/elementary/src/bin/test_actionslider.c > > trunk/TMP/st/elementary/src/lib/elm_actionslider.c Removed: > > trunk/TMP/st/elementary/src/bin/test_magnetslider.c > > trunk/TMP/st/elementary/src/lib/elm_magnetslider.c Modified: > > trunk/TMP/st/elementary/data/themes/default.edc > > trunk/TMP/st/elementary/src/bin/Makefile.am > > trunk/TMP/st/elementary/src/bin/test.c > > trunk/TMP/st/elementary/src/lib/Elementary.h.in > > trunk/TMP/st/elementary/src/lib/Makefile.am > > > > Modified: trunk/TMP/st/elementary/data/themes/default.edc > > =================================================================== > > --- trunk/TMP/st/elementary/data/themes/default.edc 2010-12-01 09:46:49 > > UTC (rev 55115) +++ trunk/TMP/st/elementary/data/themes/default.edc > > 2010-12-01 09:54:20 UTC (rev 55116) @@ -14870,9 +14870,9 @@ > > } > > > > //////////////////////////////////////////////////////////////////////////////// > > -// magnetslider > > +// actionslider > > //////////////////////////////////////////////////////////////////////////////// > > - group { name: "elm/magnetslider/base/default"; > > + group { name: "elm/actionslider/base/default"; > > > > images { > > image: "shelf_inset.png" COMP; > > @@ -14983,8 +14983,8 @@ > > } > > } > > > > - group { name: "elm/magnetslider/icon/default"; > > - alias: "elm/magnetslider/icon/bar"; > > + group { name: "elm/actionslider/icon/default"; > > + alias: "elm/actionslider/icon/bar"; > > > > images { > > image: "bt_bases.png" COMP; > > @@ -15044,7 +15044,7 @@ > > } > > } > > > > - group { name: "elm/magnetslider/base/bar"; > > + group { name: "elm/actionslider/base/bar"; > > > > images { > > image: "shelf_inset.png" COMP; > > > > Modified: trunk/TMP/st/elementary/src/bin/Makefile.am > > =================================================================== > > --- trunk/TMP/st/elementary/src/bin/Makefile.am 2010-12-01 09:46:49 UTC > > (rev 55115) +++ trunk/TMP/st/elementary/src/bin/Makefile.am 2010-12-01 > > 09:54:20 UTC (rev 55116) @@ -53,7 +53,7 @@ > > test_inwin.c \ > > test_scaling.c \ > > test_slider.c \ > > -test_magnetslider.c \ > > +test_actionslider.c \ > > test_genlist.c \ > > test_check.c \ > > test_pager.c \ > > > > Modified: trunk/TMP/st/elementary/src/bin/test.c > > =================================================================== > > --- trunk/TMP/st/elementary/src/bin/test.c 2010-12-01 09:46:49 UTC > > (rev 55115) +++ trunk/TMP/st/elementary/src/bin/test.c 2010-12-01 > > 09:54:20 UTC (rev 55116) @@ -57,7 +57,7 @@ > > void test_scaling(void *data, Evas_Object *obj, void *event_info); > > void test_scaling2(void *data, Evas_Object *obj, void *event_info); > > void test_slider(void *data, Evas_Object *obj, void *event_info); > > -void test_magnetslider(void *data, Evas_Object *obj, void *event_info); > > +void test_actionslider(void *data, Evas_Object *obj, void *event_info); > > void test_genlist(void *data, Evas_Object *obj, void *event_info); > > void test_genlist2(void *data, Evas_Object *obj, void *event_info); > > void test_genlist3(void *data, Evas_Object *obj, void *event_info); > > @@ -291,7 +291,7 @@ > > ADD_TEST("Scaling", test_scaling); > > ADD_TEST("Scaling 2", test_scaling2); > > ADD_TEST("Slider", test_slider); > > - ADD_TEST("Magnetslider", test_magnetslider); > > + ADD_TEST("Actionslider", test_actionslider); > > ADD_TEST("Genlist", test_genlist); > > ADD_TEST("Genlist 2", test_genlist2); > > ADD_TEST("Genlist 3", test_genlist3); > > > > Modified: trunk/TMP/st/elementary/src/lib/Elementary.h.in > > =================================================================== > > --- trunk/TMP/st/elementary/src/lib/Elementary.h.in 2010-12-01 09:46:49 > > UTC (rev 55115) +++ trunk/TMP/st/elementary/src/lib/Elementary.h.in > > 2010-12-01 09:54:20 UTC (rev 55116) @@ -1614,26 +1614,26 @@ > > EAPI void elm_slider_indicator_show_set(Evas_Object *obj, > > Eina_Bool show); EAPI Eina_Bool elm_slider_indicator_show_get > > (const Evas_Object *obj); > > > > - /* magnetslider */ > > - typedef enum _Elm_Magnetslider_Pos > > + /* actionslider */ > > + typedef enum _Elm_Actionslider_Pos > > { > > - ELM_MAGNETSLIDER_NONE = 0, > > - ELM_MAGNETSLIDER_LEFT = 1 << 0, > > - ELM_MAGNETSLIDER_CENTER = 1 << 1, > > - ELM_MAGNETSLIDER_RIGHT = 1 << 2, > > - ELM_MAGNETSLIDER_ALL = (1 << 3) -1 > > - } Elm_Magnetslider_Pos; > > + ELM_ACTIONSLIDER_NONE = 0, > > + ELM_ACTIONSLIDER_LEFT = 1 << 0, > > + ELM_ACTIONSLIDER_CENTER = 1 << 1, > > + ELM_ACTIONSLIDER_RIGHT = 1 << 2, > > + ELM_ACTIONSLIDER_ALL = (1 << 3) -1 > > + } Elm_Actionslider_Pos; > > > > - EAPI Evas_Object *elm_magnetslider_add(Evas_Object *parent); > > - EAPI void elm_magnetslider_labels_set(Evas_Object > > *obj, const char *left_label, const char *center_label, const char > > *right_label); > > - EAPI void elm_magnetslider_labels_get(const > > Evas_Object *obj, const char **left_label, const char **center_label, const > > char **right_label); > > - EAPI const char *elm_magnetslider_selected_label_get(const > > Evas_Object *obj); > > - EAPI void elm_magnetslider_indicator_pos_set > > (Evas_Object *obj, Elm_Magnetslider_Pos pos); > > - EAPI Elm_Magnetslider_Pos elm_magnetslider_indicator_pos_get(const > > Evas_Object *obj); > > - EAPI void elm_magnetslider_magnet_pos_set(Evas_Object > > *obj, Elm_Magnetslider_Pos pos); > > - EAPI Elm_Magnetslider_Pos elm_magnetslider_magnet_pos_get(const > > Evas_Object *obj); > > - EAPI void elm_magnetslider_enabled_pos_set(Evas_Object > > *obj, Elm_Magnetslider_Pos pos); > > - EAPI Elm_Magnetslider_Pos elm_magnetslider_enabled_pos_get(const > > Evas_Object *obj); > > + EAPI Evas_Object *elm_actionslider_add(Evas_Object *parent); > > + EAPI void elm_actionslider_labels_set(Evas_Object > > *obj, const char *left_label, const char *center_label, const char > > *right_label); > > + EAPI void elm_actionslider_labels_get(const > > Evas_Object *obj, const char **left_label, const char **center_label, const > > char **right_label); > > + EAPI const char *elm_actionslider_selected_label_get(const > > Evas_Object *obj); > > + EAPI void elm_actionslider_indicator_pos_set > > (Evas_Object *obj, Elm_Actionslider_Pos pos); > > + EAPI Elm_Actionslider_Pos elm_actionslider_indicator_pos_get(const > > Evas_Object *obj); > > + EAPI void elm_actionslider_magnet_pos_set(Evas_Object > > *obj, Elm_Actionslider_Pos pos); > > + EAPI Elm_Actionslider_Pos elm_actionslider_magnet_pos_get(const > > Evas_Object *obj); > > + EAPI void elm_actionslider_enabled_pos_set(Evas_Object > > *obj, Elm_Actionslider_Pos pos); > > + EAPI Elm_Actionslider_Pos elm_actionslider_enabled_pos_get(const > > Evas_Object *obj); /* smart callbacks called: > > * "selected" - when user selects a position (the label is passed as > > * event info)". > > > > Modified: trunk/TMP/st/elementary/src/lib/Makefile.am > > =================================================================== > > --- trunk/TMP/st/elementary/src/lib/Makefile.am 2010-12-01 09:46:49 UTC > > (rev 55115) +++ trunk/TMP/st/elementary/src/lib/Makefile.am 2010-12-01 > > 09:54:20 UTC (rev 55116) @@ -64,7 +64,7 @@ > > elm_toolbar.c \ > > elm_list.c \ > > elm_slider.c \ > > -elm_magnetslider.c \ > > +elm_actionslider.c \ > > elm_genlist.c \ > > elm_check.c \ > > elm_radio.c \ > > > > > > ------------------------------------------------------------------------------ > > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > > Tap into the largest installed PC base & get more eyes on your game by > > optimizing for Intel(R) Graphics Technology. Get started today with the > > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > > http://p.sf.net/sfu/intelisp-dev2dev > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > ------------------------------------------------------------------------------ > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
