On Sun, 12 Dec 2010, Cedric BAIL wrote:

> On Sat, Dec 11, 2010 at 1:39 AM, Enlightenment SVN
> <no-re...@enlightenment.org> wrote:
>> Log:
>> put EINA_MAGIC at the end of the structure
>>
>
> Why did you move EINA_MAGIC at the end, it's more likely to trigger a
> segv than protect the library and data corruption ?

then move all the other EINA_MAGIC that are also at the en of a struct 
(see eina_array.c for example).

I have no idea if EINA_MAGIC should go at the end or the beginning of a 
struct. But there is no doc, and the code sometimes put it at the end, 
sometimes at the begin. So if there is a problem, you can fix all the code 
around.

Vincent

------------------------------------------------------------------------------
Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL,
new data types, scalar functions, improved concurrency, built-in packages, 
OCI, SQL*Plus, data movement tools, best practices and more.
http://p.sf.net/sfu/oracle-sfdev2dev 
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to