Thank you, Raster. I'll keep your advices in mind. :)
-----Original Message----- From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] Sent: Friday, December 17, 2010 7:47 PM To: Myungjae Lee Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [PATCH] elm scroller, scrolled entry: events propagation, min size On Wed, 15 Dec 2010 19:22:16 +0900 Myungjae Lee <mjae....@samsung.com> said: looks good - some mistakes you made. you forgot the patch that adds elm_scroller_propagate_events_set() to Elementary.h.in .... i added it for you. but remember to include it in your patch next time. Also the documentation could be a LOT better! i fixed that for you too. also - you could have added a elm_scroller_propagate_events_get(). i added that too for you. oh.. and you didn't use ELM_CHECK_WIDTYPE(). > Hello, all. > > It's not possible to connect event handler such as EVAS_CALLBACK_KEY_UP to > elm_scrolled_entry because the scroller inside the scrolled entry does not > propagate events. So this is the patch for adding events propagation set > function to scroller and setting it to EINA_TRUE in elm scrolled entry. > > And one more thing in scrolled entry, while evaluating its size, scrolled > entry does not consider its min size. > (It just refers to the min size of its scroller object instead of scrolled > entry object.) > So here in the attached patch, scrolled entry compares its min size to the > min size of the scroller object and set the bigger one to its min size to > keep the min size set by intent. > > Please review this and give me a feedback if it doesn't meet any other > requirement. > > Thanks. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
