Some mistake in patch file.
I re-attached
Thanks.
-----Original Message-----
From: Jeonghyun Yun [mailto:jh0506....@samsung.com]
Sent: Monday, December 27, 2010 12:38 PM
To: 'enlightenment-devel@lists.sourceforge.net'
Subject: [E-devel] [Patch] small patch for elm_gengrid.c
Hello
I found one small bug in elm_gengrid.c
"item" is used after "free(item)" in elm_gengrid_item_del() function.
Can anybody check about this ?
Thanks.
Index: src/lib/elm_gengrid.c
===================================================================
--- src/lib/elm_gengrid.c (revision 55760)
+++ src/lib/elm_gengrid.c (working copy)
@@ -242,6 +242,7 @@ static void _item_hilight(Elm_Gengrid_Item *i
static void _item_unrealize(Elm_Gengrid_Item *item);
static void _item_select(Elm_Gengrid_Item *item);
static void _item_unselect(Elm_Gengrid_Item *item);
+static void _calc_job(void *data);
static void _on_focus_hook(void *data,
Evas_Object *obj);
static Eina_Bool _item_multi_select_up(Widget_Data *wd);
@@ -1177,6 +1178,8 @@ _item_del(Elm_Gengrid_Item *item)
item->tooltip.del_cb((void *)item->tooltip.data, item->base.widget, item);
item->wd->walking -= item->walking;
item->wd->count--;
+ if (item->wd->calc_job) ecore_job_del(item->wd->calc_job);
+ item->wd->calc_job = ecore_job_add(_calc_job, item->wd);
elm_widget_item_del(item);
}
@@ -1859,9 +1862,6 @@ elm_gengrid_item_del(Elm_Gengrid_Item *item)
}
_item_del(item);
-
- if (item->wd->calc_job) ecore_job_del(item->wd->calc_job);
- item->wd->calc_job = ecore_job_add(_calc_job, item->wd);
}
/**
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
