Commited, thanks. * Daniel Juyung Seo <juyung....@samsung.com> [2011-01-05 22:50:37 +0900]:
> Hello, > I fixed a bug for elm_genlist_item_insert_before/after() declarations. > (Thanks glima.) > > I should have modified EINA_ARG_NONNULL() when I added a new parameter. > 1st and 5th parameter should not be NULL. > > Anybody can review and apply this to upstream? > > Thanks. > Daniel Juyung Seo (SeoZ) > > -----Original Message----- > From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] > Sent: Wednesday, January 05, 2011 3:04 PM > To: Daniel Juyung Seo > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] [Patch] Tree support for > elm_genlist_item_insert_before/after() APIs > > On Thu, 30 Dec 2010 14:04:00 +0900 Daniel Juyung Seo > <juyung....@samsung.com> > said: > > thanks! in svn! > > > Hello, > > I added tree feature support to > > elm_genlist_item_insert_before/after() APIs. > > > > This patch assumes that the previous patch, '[E-devel] [Patch] Tree > support > > for elm_genlist_item_prepend() API.', is already applied to upstream. > > So this patch does not include the changes of the previous patch. > > > > This patch includes API break. I added parent parameter. > > To support genlist group index feature, it should have a parent parameter > > like elm_genlist_item_append/prepend() do. > > Raster already agreed to this API break. > > I or my co-worker will introduce genlist group index feature today. > > But for the reviewer's convenience, I separated this patch. > > > > - 001.elm_genlist.patch.txt > > Patch for src/lib/elm_genlist.c > > - 002.elm_genlist.patch.txt > > Patch for src/lib/Elementary.h.in, src/bin/test_genlist.c > > - 003.elm_genlist.patch.txt > > Due to API break, I changes other EFL libraries and applications on > SVN. > > > > Anybody can review this and please apply previous patch first then apply > > this patch next. > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > Index: src/lib/Elementary.h.in > =================================================================== > --- src/lib/Elementary.h.in (revision 55878) > +++ src/lib/Elementary.h.in (working copy) > @@ -1730,8 +1730,8 @@ extern "C" { > /* operations to add items */ > EAPI Elm_Genlist_Item *elm_genlist_item_append(Evas_Object *obj, const > Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *parent, > Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data) > EINA_ARG_NONNULL(1); > EAPI Elm_Genlist_Item *elm_genlist_item_prepend(Evas_Object *obj, const > Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item *parent, > Elm_Genlist_Item_Flags flags, Evas_Smart_Cb func, const void *func_data) > EINA_ARG_NONNULL(1); > - EAPI Elm_Genlist_Item *elm_genlist_item_insert_before(Evas_Object *obj, > const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item > *parent, Elm_Genlist_Item *before, Elm_Genlist_Item_Flags flags, > Evas_Smart_Cb func, const void *func_data) EINA_ARG_NONNULL(1, 4); > - EAPI Elm_Genlist_Item *elm_genlist_item_insert_after(Evas_Object *obj, > const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item > *parent, Elm_Genlist_Item *after, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb > func, const void *func_data) EINA_ARG_NONNULL(1, 4); > + EAPI Elm_Genlist_Item *elm_genlist_item_insert_before(Evas_Object *obj, > const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item > *parent, Elm_Genlist_Item *before, Elm_Genlist_Item_Flags flags, > Evas_Smart_Cb func, const void *func_data) EINA_ARG_NONNULL(1, 5); > + EAPI Elm_Genlist_Item *elm_genlist_item_insert_after(Evas_Object *obj, > const Elm_Genlist_Item_Class *itc, const void *data, Elm_Genlist_Item > *parent, Elm_Genlist_Item *after, Elm_Genlist_Item_Flags flags, Evas_Smart_Cb > func, const void *func_data) EINA_ARG_NONNULL(1, 5); > /* operations to retrieve existing items */ > EAPI Elm_Genlist_Item *elm_genlist_selected_item_get(const Evas_Object > *obj) EINA_ARG_NONNULL(1); > EAPI const Eina_List *elm_genlist_selected_items_get(const Evas_Object > *obj) EINA_ARG_NONNULL(1); > ------------------------------------------------------------------------------ > Learn how Oracle Real Application Clusters (RAC) One Node allows customers > to consolidate database storage, standardize their database environment, and, > should the need arise, upgrade to a full multi-node Oracle RAC database > without downtime or disruption > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Lima Chaves Computer Engineer @ ProFUSION Embedded Systems ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
