On 02/06/2011 08:58 AM, Ravenlock wrote: > On 02/05/2011 20:53, Mike Blumenkrantz wrote: >> On Sat, 05 Feb 2011 21:25:32 -0500 >> Christopher Michael<cpmicha...@comcast.net> wrote: >> >>> On 02/05/2011 09:04 PM, Enlightenment SVN wrote: >>>> Log: >>>> Allow users to remove border resistance on a per border basis. >>>> >>>> Author: ravenlock >>>> Date: 2011-02-05 18:04:37 -0800 (Sat, 05 Feb 2011) >>>> New Revision: 56745 >>>> Trac: http://trac.enlightenment.org/e/changeset/56745 >>>> >>>> Modified: >>>> trunk/e/src/bin/e_border.c trunk/e/src/bin/e_border.h >>>> trunk/e/src/bin/e_config.c trunk/e/src/bin/e_config.h >>>> trunk/e/src/bin/e_int_border_menu.c trunk/e/src/bin/e_int_border_remember.c >>>> trunk/e/src/bin/e_remember.c trunk/e/src/bin/e_remember.h >>>> trunk/e/src/bin/e_resist.c >>>> >>>> Modified: trunk/e/src/bin/e_border.h >>>> =================================================================== >>>> --- trunk/e/src/bin/e_border.h 2011-02-06 01:53:33 UTC (rev 56744) >>>> +++ trunk/e/src/bin/e_border.h 2011-02-06 02:04:37 UTC (rev 56745) >>>> @@ -443,6 +443,7 @@ >>>> unsigned int need_maximize : 1; >>>> E_Maximize maximized; >>>> unsigned int borderless : 1; >>>> + unsigned int offer_resistance : 1; >>>> const char *bordername; >>>> >>>> unsigned int lock_user_location : 1; /*DONE*/ >>>> >>>> Modified: trunk/e/src/bin/e_config.c >>>> =================================================================== >>>> --- trunk/e/src/bin/e_config.c 2011-02-06 01:53:33 UTC (rev 56744) >>>> +++ trunk/e/src/bin/e_config.c 2011-02-06 02:04:37 UTC (rev 56745) >>>> @@ -470,6 +470,7 @@ >>>> E_CONFIG_VAL(D, T, prop.command, STR); >>>> E_CONFIG_VAL(D, T, prop.icon_preference, UCHAR); >>>> E_CONFIG_VAL(D, T, prop.desktop_file, STR); >>>> + E_CONFIG_VAL(D, T, prop.offer_resistance, UCHAR); >>>> >>>> Modified: trunk/e/src/bin/e_remember.h >>>> =================================================================== >>>> --- trunk/e/src/bin/e_remember.h 2011-02-06 01:53:33 UTC (rev 56744) >>>> +++ trunk/e/src/bin/e_remember.h 2011-02-06 02:04:37 UTC (rev 56745) >>>> @@ -25,6 +25,7 @@ >>>> #define E_REMEMBER_APPLY_ICON_PREF (1<< 13) >>>> #define E_REMEMBER_SET_FOCUS_ON_START (1<< 14) >>>> #define E_REMEMBER_APPLY_FULLSCREEN (1<< 15) >>>> +#define E_REMEMBER_APPLY_OFFER_RESISTANCE (1<< 16) >>>> >>>> #define E_REMEMBER_INTERNAL_DIALOGS (1<< 0) >>>> #define E_REMEMBER_INTERNAL_FM_WINS (1<< 1) >>>> @@ -88,6 +89,7 @@ >>>> unsigned char skip_pager; >>>> unsigned char skip_taskbar; >>>> unsigned char icon_preference; >>>> + unsigned char offer_resistance; >>>> >>>> int desk_x, desk_y; >>>> int zone; >>>> >>> Something seems a little strange with this. E_Border.h declares >>> offer_resistance as unsigned int, but e_config (and e_remember) has the >>> property as unsigned char ?? >>> >>> dh >>> >> New (old) svn breaker? :D >> > > I'll make the recommended adjustments. :) > > If that's your definition of breaking svn, I'll surely be the most > guilty (as dh can point out). However, if you'd like to see *my* > definition of broken.... I'd be happy to oblige. ;) >
Well, don't get me wrong here. I'm not saying that anything is 'broken' ... if the compiles fine and runs (which it does), then it's not 'broken' in that sense :) I'm was simply saying that in one place the variable is defined as uint, and in another as uchar. Perhaps we should just use Eina_Bool in both places for consistency ?? dh ------------------------------------------------------------------------------ The modern datacenter depends on network connectivity to access resources and provide services. The best practices for maximizing a physical server's connectivity to a physical network are well understood - see how these rules translate into the virtual world? http://p.sf.net/sfu/oracle-sfdevnlfb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
