Hello

 

I fixed one small strange code in elm_gengrid.

 

"item" null checked after used item in elm_gengrid_item_selected_set()
function.

 

I deleted null checking code because already done in
ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN.

 

Can anybody check about this ? 

 

Thanks. 

 

Index: src/lib/elm_gengrid.c
===================================================================
--- src/lib/elm_gengrid.c       (revision 56885)
+++ src/lib/elm_gengrid.c       (working copy)
@@ -2206,7 +2206,7 @@ elm_gengrid_item_selected_set(Elm_Gengrid_Item *it
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(item);
    Widget_Data *wd = item->wd;
    if (!wd) return;
-   if ((!item) || (item->delete_me)) return;
+   if (item->delete_me) return;
    selected = !!selected;
    if (item->selected == selected) return;
 
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to