Dear Hyoyoung, There are some coding conventions issues in your patch, for example: for example the spaces around the + in this line: "eqchar = strchr(curlocater+key_len, '=');"
Please fix those and re-send the patch. Also, if possible please also include a quick explanation on what the problem was and what's the fix. Govind: We'll wait for the revised patch. Thanks, Tom. On Thu, 2011-01-13 at 16:10 +0900, Hyoyoung Chang wrote: > Dear Elementary developers. > > It's a bugfix patch at elm_label. > Revised some char iteration and fix potential null ptr ref in > strbuf_key_value_replace. > > Thank you. > > ------------------------------------------- > Hyoyoung CHANG > Engineer > > SAMSUNG ELECTRONICS, Co., Ltd. > E-mail: hyoyoung.ch...@samsung.com > ------------------------------------------- > > ------------------------------------------------------------------------------ > Protect Your Site and Customers from Malware Attacks > Learn about various malware tactics and how to avoid them. Understand > malware threats, the impact they can have on your business, and how you > can protect your company and customers by using code signing. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ enlightenment-devel mailing > list enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
