They found their patch, please wait for them to revise it and then we'll just commit that one (just to make the small merge easier).
Thanks, Tom. On Thu, 2011-02-10 at 15:26 +0200, Tom Hacohen wrote: > It's cleaner and more readable to do to do > (*replocater) instead of (*replocater != '\0'). > But other than that it looks like a solid patch that should go in > anyway... > > -- > Tom. > > On Thu, 2011-02-10 at 14:19 +0100, Atton Jonathan wrote: > > > > The patch of elm_label. Maybe somsung has a better patch. Tell me if I > > should commit it or not. > > > > 2011/2/10 GOVINDARAJU SM <govi...@samsung.com> > > Hi Tom, > > > > SegmentControl uses elm_label internally ( for font size > > reduction to > > fit the text and for ellipsis ). There is a bug in elm_label > > which > > makes segment control crash on opensource SVN. > > We will submit patch for elm_label to fix the issue. > > > > And, detail on Segment control Widget: Segment control groups > > toggle > > button kind of items and allows only one item to be in > > selected state. > > In overall, it will look like a Single button, with multiple > > segments > > and any one segment can be in selected state. > > > > ui-mirroring : This is not show stopper, and prefer to make > > follow on > > patch. Hope this is okay. > > > > > > Regards, > > Govind > > > > > > > > Tom Hacohen wrote: > > > Ok, correction: > > > I applied the patch and tried it, the test at elementary > > test segs for > > > me. Please make sure it works in EFL without samsung > > modifications. > > > > > > -- > > > Tom. > > > > > > On Thu, 2011-02-10 at 07:52 +0000, Tom Hacohen wrote: > > > > > >> Hey Daniel, > > >> > > >> Could you please explain a bit about this widget? (for > > those of us that > > >> are too lazy to try it) > > >> > > >> And please also generate a patch so it'll be easier for all > > of us to > > >> test. > > >> > > >> One last comment: I didn't yet test it, so I don't know if > > it even makes > > >> sense for this widget, but it doesn't have any ui-mirroring > > support. > > >> Please forward them my previous email about ui-mirroring in > > elementary > > >> and what developers are required to do in new widgets. As > > it stands, > > >> this widget is not complete. > > >> > > >> Thanks, > > >> Tom. > > >> > > >> On Thu, 2011-02-10 at 14:13 +0900, Daniel Juyung Seo wrote: > > >> > > >>> Hello, > > >>> Govindaraju SM and Prince Kumar Dubey sent me a new widget > > >>> elm_segment_control. > > >>> They're not allowed to send a file to out of company. :( > > >>> Anybody can review this? > > >>> I attached screenshot and patch codes. > > >>> And below are an email from them. > > >>> Thanks. > > >>> > > >>> Daniel Juyung Seo (SeoZ) > > >>> > > >>> ---------------------------------------------- > > >>> Dear Daniel, > > >>> > > >>> Can you post the attached patch to EFL community? This > > patch contains a > > >>> fresh new widget Segment Control. > > >>> > > >>> This code went through many rounds internal review > > ( including > > >>> Rasterman's review ) and finally ready for upstreaming. > > >>> > > >>> Patch: New elementary widget: elm_segment_control. > > >>> ==================== > > >>> Authors: Govindaraju SM <govi...@samsung.com>, Prince > > Kumar Dubey > > >>> <prince.du...@samsung.com> > > >>> Change Log: New widget elm_segment_control. Segment > > Control Widget is > > >>> a horizontal control made of multiple segment items > > together, each > > >>> segment item functioning similar to discrete two state > > button. Only one > > >>> Segment item can be at selected state. > > >>> ==================== > > >>> > > >>> Please refer the attached file > > SegmentControl_screenshot.png for the > > >>> widget screenshot. > > >>> > > >>> Thank you. > > >>> > > >>> Regards, > > >>> Govind > > >>> > > >>> > > > > ------------------------------------------------------------------------------ > > >>> The ultimate all-in-one performance toolkit: Intel(R) > > Parallel Studio XE: > > >>> Pinpoint memory and threading errors before they happen. > > >>> Find and fix more than 250 security defects in the > > development cycle. > > >>> Locate bottlenecks in serial and parallel code that limit > > performance. > > >>> http://p.sf.net/sfu/intel-dev2devfeb > > >>> _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >>> > > >> > > >> > > > > ------------------------------------------------------------------------------ > > >> The ultimate all-in-one performance toolkit: Intel(R) > > Parallel Studio XE: > > >> Pinpoint memory and threading errors before they happen. > > >> Find and fix more than 250 security defects in the > > development cycle. > > >> Locate bottlenecks in serial and parallel code that limit > > performance. > > >> http://p.sf.net/sfu/intel-dev2devfeb > > >> _______________________________________________ > > >> enlightenment-devel mailing list > > >> enlightenment-devel@lists.sourceforge.net > > >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > The ultimate all-in-one performance toolkit: Intel(R) > > Parallel Studio XE: > > > Pinpoint memory and threading errors before they happen. > > > Find and fix more than 250 security defects in the > > development cycle. > > > Locate bottlenecks in serial and parallel code that limit > > performance. > > > http://p.sf.net/sfu/intel-dev2devfeb > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > ------------------------------------------------------------------------------ > > The ultimate all-in-one performance toolkit: Intel(R) Parallel > > Studio XE: > > Pinpoint memory and threading errors before they happen. > > Find and fix more than 250 security defects in the development > > cycle. > > Locate bottlenecks in serial and parallel code that limit > > performance. > > http://p.sf.net/sfu/intel-dev2devfeb > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > -- > > Regards. > > > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
