Yes, Tom did secretly :) -----Original Message----- From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] Sent: Sunday, February 27, 2011 6:14 PM To: Jihoon Kim Cc: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [PATCH] ecore_imf_context_canvas_get, ecore_imf_context_window_get
On Tue, 22 Feb 2011 23:39:28 +0900 Jihoon Kim <imfin...@gmail.com> said: yes - that's true. looks like someone put it in already :) > Thank you, raster. > Version information (@since 1.1.0) should be inserted, is it right? > Attached patch file includes it. > > On Mon, Feb 21, 2011 at 3:22 PM, Carsten Haitzler <ras...@rasterman.com>wrote: > > > On Sun, 20 Feb 2011 18:05:56 +0900 Jihoon Kim <imfin...@gmail.com> said: > > > > happiness! in svn! thanks! > > > > > Hi, Mike. > > > According to your comment, I revised this patch file. > > > Would you please review again? > > > > > > On Sun, Feb 20, 2011 at 2:27 AM, Mike Blumenkrantz <m...@zentific.com > > >wrote: > > > > > > > On Sat, 19 Feb 2011 10:13:27 +0900 > > > > Jihoon Kim <jihoon48....@samsung.com> wrote: > > > > > > > > > Hi, > > > > > > > > > > This patch includes the code to add ecore_imf_context_canvas_get and > > > > > ecore_imf_context_window_get. > > > > > These APIs are coupled with the ecore_imf_context_canvas_set and > > > > > ecore_imf_context_window_set. > > > > > Would you please review it? > > > > > > > > > Looks good, but your formatting is a little off: > > > > void* function_name(void); /* INCORRECT */ > > > > void *function_name(void); /* CORRECT */ > > > > > > > > Please fix this and resend :) > > > > > > > > -- > > > > Mike Blumenkrantz > > > > Zentific: NULL pointer dereferences now 50% off! > > > > > > > > > > > > > > ---------------------------------------------------------------------------- -- > > > > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio > > XE: > > > > Pinpoint memory and threading errors before they happen. > > > > Find and fix more than 250 security defects in the development cycle. > > > > Locate bottlenecks in serial and parallel code that limit performance. > > > > http://p.sf.net/sfu/intel-dev2devfeb > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ---------------------------------------------------------------------------- -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
