Dear Jihoon, Thanks a lot for the patch, I have one question and one comment: Question: In line 89 of the patch, you added: edje_object_message_signal_process(wd->ent);
Why is it needed there? Comment: I think all the + elm_entry_cursor_pos_set(obj, wd->cursor_pos); + if (elm_widget_focus_get(obj)) + edje_object_signal_emit(wd->ent, "elm,action,focus", "elm"); are not needed everywhere, but only in theme_hook. Does it work if you remove it from everywhere except for theme_hook? if not, there's probably something wrong that should be fixed, because this is what theme_hook is for (updating the widget when the theme changes, among others). Thanks, Tom. On Wed, 2011-03-16 at 16:57 +0900, Jihoon Kim wrote: > Hello. > > Whenever the theme (edj) is changed in entry, the cursor position in entry > is reset > because elm_entry does not save the cursor position in the entry. > > This patch is for keeping the cursor position in entry regardless of > changing theme (edj). > It will save the cursor position in entry and set the cursor position again > after changing theme. > > Would you please review this patch? > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
