It's only the number of items shown, I don't think the programmer should
care but this is really just a matter of ui-design. Theme should not
care this has changed, we should just write the theme generic enough.
I don't see how setting the default value in the theme is different than
setting it in the app :)
Item count: that's almost always more than the number of items in the
theme, that's the whole point, it's only the number of items visible at
each moment, which is usually small.
--
Tom.
On Tue, 2011-03-22 at 14:40 +0000, ChunEon Park wrote:
> Hmm, yes, they can do .
>
>
>
> And you are right.
>
>
>
> But for example,
>
> If original default theme set the count of items 3,
>
> and the item count is changed to 100 by the new theme.
>
> and they need to set the each item text differently,
>
>
>
> then how do they set the extra 997 items usefully?
>
>
>
> They can modify look & feel but not good at item count.
>
>
>
> Even they just modified count 3 to 4,
>
> theme writer should consider that what item selected event will be
> happend for new one. (in the c code)
>
> They will have limitations in consequently.
>
>
>
> Cause of the above cases,
>
> Many developers(both theme, c writer) would be more unhappy because
> they should consider more things to understand lines.
>
> but only few cases can be more happy.
>
>
>
> That was my thought . :)
>
>
>
> - Hermet.
>
>
>
> ------- Original Message -------
>
> Sender : Tom Hacohen<tom.haco...@partner.samsung.com>
> Engineer/STRI-SLP RTL Language supporting/삼성전자
>
> Date : 2011-03-22 20:40 (GMT+09:00)
>
> Title : Re: [E-devel] [Patch] Display more than 3 items
>
>
>
> I don'c quite follow. The user can change the theme to change the
> default behavior, and an application can override it through API, I
> don't see how setting it in the theme is not useful.
>
> --
> Tom.
>
> On Tue, 2011-03-22 at 20:31 +0900, ChunEon Park wrote:
> > But I guess the data count in the theme does not useful.
> >
> >
> >
> > Even user change the theme, the count could not be changed.
> >
> > Because each items could be set only in the code.
> >
> >
> >
> > ------------------------------------
> > Let's run together for the best moment!
> >
> > -Regards, Hermet-
> >
> >
> >
> > -----Original Message-----
> > From: "Tom Hacohen"
> > To: "Daniel Juyung Seo"
> > Cc: enlightenment-devel@lists.sourceforge.net;
> > "cnook"
> > Sent: 11-03-22(화) 17:08:37
> > Subject: Re: [E-devel] [Patch] Display more than 3 items
> >
> > You can load default from the theme and modify it with API...
> >
> > On Tue, 2011-03-22 at 13:47 +0900, Daniel Juyung Seo wrote:
> > > Hello.
> > >
> > > > then several different theme file have to be existed. In this
> > case, API
> > > > would be more efficient.
> > >
> > > Hmm... you're right. It will be more flexible to use API for item
> > count.
> > > If we use previously suggested idea, we need to prepare many item
> > > styles for several cases.
> > > And that doesn't look that flexible.
> > >
> > > And one more comment.
> > > You don't need to write separate sample application.
> > > Just add the sample to elementary_test.
> > >
> > > Thanks.
> > > Daniel Juyung Seo (SeoZ)
> > >
> > > On Mon, Mar 21, 2011 at 10:39 PM, cnook wrote:
> > > > Dear All,
> > > >
> > > > Hi~
> > > > Thanks for your response always!
> > > >
> > > > I have changed the "elm_diskselector" based on your comments.
> > > > The "displayed item count" is described by using theme file.
> > > > And example source - example.tar.gz - have attached.
> > > > (If you have an example of the example :), then please inform
> and
> > send me.)
> > > >
> > > > By the way, I have something wondering about this way.
> > > > If several "elm_diskselector" are added with different
> "displayed
> > item
> > > > count" on one same parent,
> > > > then several different theme file have to be existed. In this
> > case, API
> > > > would be more efficient.
> > > >
> > > > I would like to know more about your opinion. Thanks
> > > >
> > > > Sincerely,
> > > > Shinwoo Kim.
> > > >
> > > >
> > > > 2011/3/19 Daniel Juyung Seo
> > > >>
> > > >> Check the _theme_hook().
> > > >> :)
> > > >>
> > > >> Thanks.
> > > >> Daniel Juyung Seo (SeoZ)
> > > >>
> > > >> On Sat, Mar 19, 2011 at 1:53 PM, cnook
> > wrote:
> > > >> > Dear All,
> > > >> >
> > > >> > Hi~
> > > >> >
> > > >> > Thanks for your response.
> > > >> >
> > > >> > I have tried to use "data.item" and edje_object_data_get()
> API.
> > It works
> > > >> > fine. :)
> > > >> >
> > > >> > But I met a problem. When I use a new style for
> > elm_diskselector,
> > > >> > edje_object_data_get() cannot retrieve "data.item" of new
> > style.
> > > >> >
> > > >> > Only original (default) "data.item" value is retrieved.
> > > >> >
> > > >> > Would you please let me know what I forget?
> > > >> >
> > > >> > Thanks.
> > > >> >
> > > >> >
> > > >> > Sincerely,
> > > >> > Shinwoo Kim.
> > > >> >
> > > >> >
> > > >> > 2011/3/18 Daniel Juyung Seo
> > > >> >>
> > > >> >> +3 !
> > > >> >> Using group data in theme looks better because it reduces
> > source-gui
> > > >> >> dependences.
> > > >> >>
> > > >> >> group { name: "xx";
> > > >> >> data.item: "count" "3";
> > > >> >>
> > > >> >> You can fetch this data from c source using
> > edje_object_data_get() API.
> > > >> >> Please check other widgets for a reference.
> > > >> >>
> > > >> >> I checked the patch very briefly and here are some comments.
> > > >> >>
> > > >> >> 1. Indentation.
> > > >> >> ex) line 250 in elm_diskselector.diff
> > > >> >>
> > > >> >> 2. Blank lines.
> > > >> >> There are 2 blank lines at the end of diff file. 396, 397
> > lines.
> > > >> >>
> > > >> >> 3. Diff file.
> > > >> >> I think there is no rule for this but you can merge two diff
> > files
> > > >> >> to one diff file
> > > >> >> because they are patches for a one feature and one
> > > >> >> library(elementary).
> > > >> >>
> > > >> >> 4. Sample code.
> > > >> >> It will be better to have a sample code for a new feature in
> > > >> >> elementary_test.
> > > >> >>
> > > >> >> Other than that, looks ok :)
> > > >> >>
> > > >> >> Thanks.
> > > >> >> Daniel Juyung Seo (SeoZ)
> > > >> >>
> > > >> >> On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao
> > > >> >>
> > > >> >> wrote:
> > > >> >> > +2 !
> > > >> >> >
> > > >> >> > When had see this widget in first time, I imagined it with
> > option to
> > > >> >> > many items but ever configured in theme.
> > > >> >> > If i'm right, this widget is a lot dependent of code and
> > less of
> > > >> >> > theme
> > > >> >> > :(
> > > >> >> >
> > > >> >> > What you thing about this, Shinwoo Kim?
> > > >> >> > Gustavo suggested the easiest way, use group data.
> > > >> >> >
> > > >> >> > Thanks.
> > > >> >> >
> > > >> >> >
> > > >> >> > On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri
> > > >> >> > wrote:
> > > >> >> >> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly
> >
> > > >> >> >> wrote:
> > > >> >> >>> On Thu, Mar 17, 2011 at 10:45 AM, cnook
> > wrote:
> > > >> >> >>>> Dear All,
> > > >> >> >>>
> > > >> >> >>> Hi Shinwoo Kim,
> > > >> >> >>>
> > > >> >> >>>>
> > > >> >> >>>> This is Shinwoo Kim, learned that I could contribute to
> > EFL! :)
> > > >> >> >>>> I'm pleased to inform you that the patch for the
> > > >> >> >>>> "elm_diskselector".
> > > >> >> >>>>
> > > >> >> >>>> Until now, the "elm_diskselector" only display 3 items
> at
> > once,
> > > >> >> >>>> if you accept this patch, the "elm_diskselector" can
> > display more
> > > >> >> >>>> than 3
> > > >> >> >>>> items.
> > > >> >> >>>
> > > >> >> >>> Displaying more than 3 items is a nice improvement.
> > > >> >> >>> What do you think about the idea of getting the number
> of
> > items to
> > > >> >> >>> be
> > > >> >> >>> displayed from the theme ?
> > > >> >> >>>
> > > >> >> >>> Anyway, there is a typo on documentation (param num).
> > Maybe a
> > > >> >> >>> getter
> > > >> >> >>> could be useful as well.
> > > >> >> >>
> > > >> >> >> +1 to get it from theme!
> > > >> >> >>
> > > >> >> >> I did something similar for ephoto in some older version,
> > it had
> > > >> >> >> couple of swallow parts defined, like "elm.swallow.p%d",
> > and a
> > > >> >> >> data.item: "count" "3", thus it would fill 3 swallows.
> > > >> >> >>
> > > >> >> >> I believe this is something up to the theme as it has the
> > knowledge
> > > >> >> >> on
> > > >> >> >> how to pack more items.
> > > >> >> >>
> > > >> >> >>
> > > >> >> >> --
> > > >> >> >> Gustavo Sverzut Barbieri
> > > >> >> >> http://profusion.mobi embedded systems
> > > >> >> >> --------------------------------------
> > > >> >> >> MSN: barbi...@gmail.com
> > > >> >> >> Skype: gsbarbieri
> > > >> >> >> Mobile: +55 (19) 9225-2202
> > > >> >> >>
> > > >> >> >>
> > > >> >> >>
> > > >> >> >>
> >
> ------------------------------------------------------------------------------
> > > >> >> >> Colocation vs. Managed Hosting
> > > >> >> >> A question and answer guide to determining the best fit
> > > >> >> >> for your organization - today and in the future.
> > > >> >> >> http://p.sf.net/sfu/internap-sfd2d
> > > >> >> >> _______________________________________________
> > > >> >> >> enlightenment-devel mailing list
> > > >> >> >> enlightenment-devel@lists.sourceforge.net
> > > >> >> >>
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > >> >> >>
> > > >> >> >
> > > >> >> >
> > > >> >> >
> > > >> >> > --
> > > >> >> > Tiago Rezende Campos Falcão
> > > >> >> > http://www.tiagofalcao.com
> > > >> >> > --
> > > >> >> > ProFUSION | embedded systems
> > > >> >> > Computer Systems Laboratory - IC - Unicamp
> > > >> >> > Grupo Pró Software Livre - Unicamp
> > > >> >> > Laboratory of Information Systems - IC - Unicamp
> > > >> >> >
> > > >> >> >
> > > >> >> >
> > > >> >> >
> >
> ------------------------------------------------------------------------------
> > > >> >> > Colocation vs. Managed Hosting
> > > >> >> > A question and answer guide to determining the best fit
> > > >> >> > for your organization - today and in the future.
> > > >> >> > http://p.sf.net/sfu/internap-sfd2d
> > > >> >> > _______________________________________________
> > > >> >> > enlightenment-devel mailing list
> > > >> >> > enlightenment-devel@lists.sourceforge.net
> > > >> >> >
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > >> >> >
> > > >> >
> > > >> >
> > > >
> > > >
> > >
> > >
> >
> ------------------------------------------------------------------------------
> > > Enable your software for Intel(R) Active Management Technology to
> > meet the
> > > growing manageability and security demands of your customers.
> > Businesses
> > > are taking advantage of Intel(R) vPro (TM) technology - will your
> > software
> > > be a part of the solution? Download the Intel(R) Manageability
> > Checker
> > > today! http://p.sf.net/sfu/intel-dev2devmar
> > > _______________________________________________
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Enable your software for Intel(R) Active Management Technology to
> meet
> > the
> > growing manageability and security demands of your customers.
> > Businesses
> > are taking advantage of Intel(R) vPro (TM) technology - will your
> > software
> > be a part of the solution? Download the Intel(R) Manageability
> > Checker
> > today! http://p.sf.net/sfu/intel-dev2devmar
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> >
> >
>
>
>
>
> ------------------------------------------------------------------------------
> Enable your software for Intel(R) Active Management Technology to meet
> the
> growing manageability and security demands of your customers.
> Businesses
> are taking advantage of Intel(R) vPro (TM) technology - will your
> software
> be a part of the solution? Download the Intel(R) Manageability
> Checker
> today! http://p.sf.net/sfu/intel-dev2devmar
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
>
>
>
>
>
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
