On Mon, 11 Apr 2011 21:42:16 +0200 (CEST) Vincent Torri
<vto...@univ-evry.fr> wrote:

> 
> 
> On Sat, 9 Apr 2011, David Seikel wrote:
> 
> > On Thu, 7 Apr 2011 16:40:46 +0200 (CEST) Vincent Torri
> > <vto...@univ-evry.fr> wrote:
> >
> >>
> >>
> >> On Fri, 8 Apr 2011, David Seikel wrote:
> >>
> >>> Ecore uses a call to finite(), this call seems to be obsolete.  It
> >>> is replaced by a macro isfinite().  I'm wondering if we should fix
> >>> that, and what our portability experts think?
> >>>
> >>> It's used in _ecore_main_select() in ecore_main.c.  I don't think
> >>> it is used anywhere else in current svn.
> >>>
> >>> In my current contract I'm compiling EFL using uClibc, and that
> >>> does not provide finite(), but does provide isfinite().  The
> >>> reason they say they do that is coz finite() is obsolete.
> >>>
> >>> Hmm, the Windows build files include this "finite=_finite" in
> >>> "PreprocessorDefinitions".  Seems to be basically renaming a few
> >>> functions to their Windows equivalents.
> >>
> >> If there are such problems in different libc, I would suggest to
> >> detect the function in configure.ac and add a static inline
> >> function that used the corresponding function, with a special case
> >> for Visul Studio (_finite(), no finite(), nor isfinite() nor
> >> _isfinite() (I just checked))
> >
> > Static inline?  Why not a macro?  isfinite() is supposed to be a
> > macro for what it's worth.
> 
> like the path below ?

<snip>

Looks good to me.  Should I dust of my ancient SVN commit rights and
put it in myself, or do you want to do it?

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to