On Wed, 13 Apr 2011 23:14:43 +0200 Cedric BAIL <cedric.b...@free.fr> said:

> On Wed, Apr 13, 2011 at 11:10 PM, Joerg Sonnenberger
> <jo...@britannica.bec.de> wrote:
> > On Wed, Apr 13, 2011 at 10:18:27PM +0200, Cedric BAIL wrote:
> >> On Wed, Apr 13, 2011 at 8:36 PM, Vincent Torri <vto...@univ-evry.fr> wrote:
> >> > On Wed, 13 Apr 2011, Vincent Torri wrote:
> >> >> are you sure that O_CLOEXEC and ACCESSPERMS are portable ?
> >>
> >> I hope they are. It's a pretty basic feature, being able to
> >> automatically close a fd on exec. As for ACCESSPERMS it's just a macro
> >> that should be provided by any unix system (would only means something
> >> on them, but not much in the considered case).
> >
> > Neither is portable. O_CLEXEC is a mostly Linux specific short-cut for
> > fcntl. Unless you really want to save a system call for all cost, just
> > go with the portable appracoh.
> >
> >> > and that MAP_POPULATE does not need a too recent linux kernel ?
> >
> > This should be just conditionalized.
> 
> Agreed. Both should be conditionalized with configure detection.

actually just do it the portable way (fcntl) ALL the time if you can. there is
little to no purpose here to complicate the code when not needed :)


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to