On Wed, 20 Apr 2011 16:14:04 +0900 Jihoon Kim <jihoon48....@samsung.com> said:
> Hello, EFL developers. > > To support the autocapitalization feature, I'd like to add > ecore_imf_context_autocapital_type_{set,get} API. > I will implement the autocapital feature in immodule, so the immodule > should know the autocapitalization type. > This API is for letting immodule know the autocapitalization type. > > In addition, ecore_imf_context_prediction_allow_set API is used to set > whether the IM context should allow to use the text prediction. > > Would you please review this patch? one comment? + Eina_Bool allow_prediction; any reason u dont make it a bitfield? ie allow_prediction : 1 also why not put it at struct end to keep struct smaller? avoid alignment padding issues. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Fulfilling the Lean Software Promise Lean software platforms are now widely adopted and the benefits have been demonstrated beyond question. Learn why your peers are replacing JEE containers with lightweight application servers - and what you can gain from the move. http://p.sf.net/sfu/vmware-sfemails _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel