〉〉I didn't understand. Are you using elm_layout_content_get to delete the
content ?

Nope. That was just an example. Users need to handle contents by their own
needs. That's why another elm_xxx_content_get APIs in elm don't have const I
guess.

〉〉 Why aren't you using elm_layout_unset to unparent it ?

Actually that's what I suggested. But because of the reason I explained
above which raster explained to me, I changed my mind. If this is wrong I
will fix this and another APIs.

How do you think? Any suggestions are welcomed.

Daniel Juyung Seo (SeoZ)
On Apr 29, 2011 10:37 PM, "Bruno Dilly" <bdi...@profusion.mobi> wrote:
> On Fri, Apr 29, 2011 at 9:33 AM, Enlightenment SVN
> <no-re...@enlightenment.org> wrote:
>> Log:
>> Elementary layout: Removed 'const' from elm_layout_content_get() API.
>>
>>  This API callers can handle layout content. ex)
>>  evas_object_del(content);
>
> I didn't understand. Are you using elm_layout_content_get to delete
> the content ?
> Why aren't you using elm_layout_unset to unparent it ?
>
>>
>>
>> Author:       seoz
>> Date:         2011-04-29 05:33:36 -0700 (Fri, 29 Apr 2011)
>> New Revision: 59035
>> Trac:         http://trac.enlightenment.org/e/changeset/59035
>>
>> Modified:
>>  
>> trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_layout.c
>>
>> Modified: trunk/elementary/src/lib/Elementary.h.in
>> ===================================================================
>> --- trunk/elementary/src/lib/Elementary.h.in    2011-04-29 10:50:55 UTC
(rev 59034)
>> +++ trunk/elementary/src/lib/Elementary.h.in    2011-04-29 12:33:36 UTC
(rev 59035)
>> @@ -1043,7 +1043,7 @@
>>    EAPI Eina_Bool          elm_layout_file_set(Evas_Object *obj, const
char *file, const char *group) EINA_ARG_NONNULL(1);
>>    EAPI Eina_Bool          elm_layout_theme_set(Evas_Object *obj, const
char *clas, const char *group, const char *style) EINA_ARG_NONNULL(1);
>>    EAPI void               elm_layout_content_set(Evas_Object *obj, const
char *swallow, Evas_Object *content) EINA_ARG_NONNULL(1);
>> -   EAPI const Evas_Object *elm_layout_content_get(const Evas_Object
*obj, const char *swallow) EINA_ARG_NONNULL(1);
>> +   EAPI Evas_Object       *elm_layout_content_get(const Evas_Object
*obj, const char *swallow) EINA_ARG_NONNULL(1);
>>    EAPI Evas_Object       *elm_layout_content_unset(Evas_Object *obj,
const char *swallow) EINA_ARG_NONNULL(1);
>>    EAPI void               elm_layout_text_set(Evas_Object *obj, const
char *part, const char *text) EINA_ARG_NONNULL(1);
>>    EAPI const char        *elm_layout_text_get(const Evas_Object *obj,
const char *part) EINA_ARG_NONNULL(1);
>>
>> Modified: trunk/elementary/src/lib/elm_layout.c
>> ===================================================================
>> --- trunk/elementary/src/lib/elm_layout.c       2011-04-29 10:50:55 UTC
(rev 59034)
>> +++ trunk/elementary/src/lib/elm_layout.c       2011-04-29 12:33:36 UTC
(rev 59035)
>> @@ -464,7 +464,7 @@
>>  *
>>  * @ingroup Layout
>>  */
>> -EAPI const Evas_Object *
>> +EAPI Evas_Object *
>>  elm_layout_content_get(const Evas_Object *obj, const char *swallow)
>>  {
>>    Widget_Data *wd = elm_widget_data_get(obj);
>>
>>
>>
------------------------------------------------------------------------------
>> WhatsUp Gold - Download Free Network Management Software
>> The most intuitive, comprehensive, and cost-effective network
>> management toolset available today.  Delivers lowest initial
>> acquisition cost and overall TCO of any competing solution.
>> http://p.sf.net/sfu/whatsupgold-sd
>> _______________________________________________
>> enlightenment-svn mailing list
>> enlightenment-...@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>>
>
>
------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today. Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to