On Wed, 01 Jun 2011 09:47:01 +0000 (GMT) PRINCE KUMAR DUBEY
<[email protected]> said:
ok some review of patch itself:
+ EAPI void *elm_progressbar_part_label_set(Evas_Object *obj, const
char *part, const char *label) EINA_ARG_NONNULL(1);
why does it return void *? actualyl the function itself RETURNS nothing. so
this is wrong on 2 counts. i think you meant it to just be void not void *.
+ EINA_LIST_FOREACH(wd->parts, l, info)
+ {
+ if (info->label) eina_stringshare_del(info->label);
+ if (info->name) eina_stringshare_del(info->name);
+ wd->parts = eina_list_remove(wd->parts, info);
+
+ free(info);
+ }
use EINA_LIST_FREE here. its less code (no need to remove, and no "l" needed).
+EAPI const char *
+elm_progressbar_part_label_get(const Evas_Object *obj, const char *part)
...
+ return edje_object_part_text_get(wd->progressbar, part);
umm you want to return the text from the wd->parts list, not from edje. why?
what if u set text for a part that doesnt exist? now you cant get what you
set... :)
can you send an updated patch?
>
> Hi Mr Park,
>
>
> Thanks for your comment.
>
>
> I already had discussion with Rasterman about this new API.
>
> Please visit this link for reference
> [1]http://sourceforge.net/mailarchive/message.php?msg_id=27444784.
>
>
> and this API would not make widget to break theme changing feature as we
> are handling this in _theme_hook().
>
>
> Regards,
>
> Prince
>
>
>
> ------- Original Message -------
>
> Sender : ChunEon Park<[email protected]>
>
> Date : Jun 01, 2011 14:19 (GMT+05:30)
>
> Title : RE: RE: [E-devel] [Patch] elm_progressbar patch
>
>
> Hi, prince.
>
>
> I checked your patch right before.
>
>
> But I dont like these new APIs.
>
>
> Currently progressbar provides label_set API for normal case.
>
>
> and people could add extra text with text-part in separted layout or
> elm_label or something else if they need.
>
>
> This kind of API would make the widget break theme changing.
>
>
> Doesn't it?
>
>
> Thanks.
>
>
> ------------------------------------
> Let's run together for the best moment!
> -Regards, Hermet-
>
>
> -----Original Message-----
> From: "ChunEon Park"<[email protected]>
> To: "'ChunEon Park'"<[email protected]>;
> "'EFL'"<[email protected]>
> Cc: [email protected]
> Sent: 11-05-26(목) 11:17:05
> Subject: RE: [E-devel] [Patch] elm_progressbar patchOops, I missed patch
> file.
> Try it again! :p
> -----Original Message-----
> From: ChunEon Park [mailto:[email protected]]
> Sent: Thursday, May 26, 2011 11:14 AM
> To: EFL
> Cc: [email protected]
> Subject: [E-devel] [Patch] elm_progressbar patch
> Hi,
> This patch is sent by Prince Kumar Dubey ([email protected])
> Could somebody review this patch?
> If nobody review this, then I will later.
> Thanks.
> ------------------------------------
> Let's run together for the best moment!
> -Regards, Hermet-
>
> ----------------------------------------------------------------------------
> --
> vRanger cuts backup time in half-while increasing security.
> With the market-leading solution for virtual backup and recovery,
> you get blazing-fast, flexible, and affordable data protection.
> Download your free trial now.
> [2]http://p.sf.net/sfu/quest-d2dcopy1
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> [azUrp6pvpx30FrF0FAUdtH3Xp6UqFSdZ74lRhoRmb405MrE5pHkSpB0gbrJRbXk5pZloWrd=.gi
> f]
>
>
>
>
> [cid:[email protected]]
>
> [SeenTimeChecker?
> do=705252d8974533167eb145fa4cffa29fcda6ab03264f2db82f03c9b1
> 9f0b6f57ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075
> b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0]
>
> References
>
> 1. http://sourceforge.net/mailarchive/message.php?msg_id=27444784
> 2. http://p.sf.net/sfu/quest-d2dcopy1
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
