On Thu, 2 Jun 2011 20:40:56 +0900 cnook <kimci...@gmail.com> said: > Dear Mr. Hermet, > Hello, I have attached more accurate patch based on latest elementary. The > last patch already there. > All your review items are reflected on the attached patch. > Please review this again, sorry for any inconvenient. > > Dear Mr. Raster, > Hi, Would you please let me know why you don't like the idea of swallowing? > Someday the arrow group could be a part of base group.. > Previously, I had already made as you mentioned, but Hermet did not prefer > that the arrow is part of the ctxpopup(base).
well your patch has the arrows as swallows. in the base ctxpopup... elm.swallow.arrow_up etc. i'd make it part of the base design as it can be easily designed and integrated into the look of the popup base in one logical unit. it kind of belongs together with the base - imho. > Thanks! > > Sincerely, > Shinwoo Kim. > > 2011/6/2 Carsten Haitzler <ras...@rasterman.com> > > > On Fri, 27 May 2011 19:08:44 +0900 cnook <kimci...@gmail.com> said: > > > > this one is fine. though in general i dont like the idea of swallowing the > > arrows at all - should just be part of the ctxpopup design/obj directly, > > but > > thats already there and not specific to this patch :) > > > > thanks! > > > > > Dear All, > > > > > > Hi~ > > > > > > If CtxPopup has elm_slider for content, the elm_slider indicator is > > covered > > > by CtxPopup arrow. > > > So, I have made a patch for resolving this issue. As the title the arrow > > > will be swallowed in the base. > > > Even though user uses his/her own style, the attached patch will work > > > properly. > > > > > > Sincerely, > > > Shinwoo Kim. > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
