On Fri, 17 Jun 2011 22:50:33 +0200 Mathieu Taillefumier <mathieu.taillefum...@free.fr> said:
> On 06/17/2011 10:37 PM, Christopher Michael wrote: > > On 06/17/2011 04:35 PM, Mathieu Taillefumier wrote: > >> On 06/17/2011 10:27 PM, Christopher Michael wrote: > >>> On 06/17/2011 03:55 PM, Mathieu Taillefumier wrote: > >>>> Hi, > >>>> > >>>> I finished to write the code implementing the automatic backlight > >>>> reduction after a given time of inactivity (that can be set in the > >>>> backlight menu). The patch is relatively straightforward but reviewing > >>>> is always welcome so fire up. To have the automatic backlight just set > >>>> the Dimming time to a non zero value. The automatic dimming is disabled > >>>> when the dimming time is 0. > >>>> > >>>> > >>>> Mathieu > >>>> > >>> Just one observation wrt this patch. The formatting for 'if' statements > >>> is not correct. It should be something like this: > >>> > >>> if (_bl_log_dom< 0) > >>> > >>> with a space after the 'if'. > >> > >> And !!! Corrected but it does not improve it. > >> > >> Mathieu > >>> > > > > Hmm, I still see several 'if' statements that are not corrected ;) and > > Yes, it will not change functionality of the patch, but does improve > > readability if it matches the rest of the EFL ;) > Well thank anyway, I should follow the rules that's all ;-). Enclosed > the last version of the patch that I hope contains all the "if" > correctly formatted :-). poller? every 4 ticks (0.5 sec) ? ouch! what you REALLY want is to use the screensaver notify event. this will: 1. notify you WHEN screensaver stops (when there was activity), and so you return backlight to normal state when this happens 2. notify you when screensaver starts. this is the time to go into dim mode. its ALSO when the screensaver may begin. so we need to double up using screensaver as dimming notification. polling is not that great a thing to do. avoid if you can. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
