Thanks, Tom. I am sorry, there is some mistake. I fix and send again. Thank you in advance.
-----Original Message----- From: Tom Hacohen [mailto:[email protected]] Sent: Friday, June 24, 2011 5:45 PM To: Jihoon Kim Cc: [email protected] Subject: RE: [PATCH] call "preedit,changed" instead of "changed" when preedit string is changed In svn, thanks. On Fri, 2011-06-24 at 17:30 +0900, Jihoon Kim wrote: > Tom, according to your saying, I fix the patch and send again. > If you don't like '_sizing_eval_and_signal_emit' internal function name, you > can modify :) > Would you please review again? > > -----Original Message----- > From: Tom Hacohen [mailto:[email protected]] > Sent: Friday, June 24, 2011 4:19 PM > To: Jihoon Kim > Cc: [email protected] > Subject: Re: [PATCH] call "preedit,changed" instead of "changed" when preedit > string is changed > > On Fri, 2011-06-24 at 16:02 +0900, Jihoon Kim wrote: > > For letting application distinguish, I'd like to propose to call > > "preedit,changed" signal instead of "changed" signal when the preedit string > > is changed. > > > > Would you please review this patch? > > Sounds like a good thing to have, but I do have one comment. In the > entry code, please don't copy paste the content of "entry_changed" to > "preedit_changed" but instead share the code. Especially when it's such > a delicate thing as the min size calculation stuff. > > After that will be resolved I'll commit it in. > > Thanks, > Tom. >
entry_changed_common_handling.patch
Description: Binary data
------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
