Hi Mr. Hermet,
I got your point, and have attached new patch based on your review comments.
Sincerely,
Shinwoo Kim.
2011년 6월 27일 오후 4:37, ChunEon Park <her...@hermet.pe.kr>님의 말:
> hi cnook, good patch.
>
>
>
> But it looks it does not need to deleted event callbacks in pre_hook except
> ecore event handler.
>
>
>
> They will be deleted evas internally.
>
>
>
> Thanks.
>
>
>
> -----Original Message-----
> *From:* "cnook"<kimci...@gmail.com>
> *To:* enlightenment-devel@lists.sourceforge.net
> *Cc:*
> *Sent:* 11-06-27(월) 14:19:14
> *Subject:* [E-devel] [Patch][elm_conform] add del_pre_hook for removing
> handlerDear All,
>
> Hello,
> I have got elm_confrom does not remove its handler while it is deleted.
> This patch is for that. Please review attached patch. Thanks always.
>
> Sincerely,
> Shinwoo Kim.
>
Index: src/lib/elm_conform.c
===================================================================
--- src/lib/elm_conform.c (revision 60713)
+++ src/lib/elm_conform.c (working copy)
@@ -51,6 +51,7 @@
/* local function prototypes */
static const char *widtype = NULL;
+static void _del_pre_hook(Evas_Object *obj);
static void _del_hook(Evas_Object *obj);
static void _mirrored_set(Evas_Object *obj, Eina_Bool rtl);
static void _theme_hook(Evas_Object *obj);
@@ -73,6 +74,16 @@
/* local functions */
static void
+_del_pre_hook(Evas_Object *obj)
+{
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!wd) return;
+#ifdef HAVE_ELEMENTARY_X
+ if (wd->prop_hdl) ecore_event_handler_del(wd->prop_hdl);
+#endif
+}
+
+static void
_del_hook(Evas_Object *obj)
{
Widget_Data *wd = elm_widget_data_get(obj);
@@ -454,6 +465,7 @@
elm_widget_type_set(obj, "conformant");
elm_widget_sub_object_add(parent, obj);
elm_widget_data_set(obj, wd);
+ elm_widget_del_pre_hook_set(obj, _del_pre_hook);
elm_widget_del_hook_set(obj, _del_hook);
elm_widget_theme_hook_set(obj, _theme_hook);
elm_widget_can_focus_set(obj, EINA_FALSE);
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
