Hi, raster and EFL developers.

At revision 59894 (http://trac.enlightenment.org/e/changeset/59894) that my
patch is applied,
the function declarations is applied in svn, but I missed the implementation
code of some APIs.

Would you please review this patch?

-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:[email protected]] 
Sent: Thursday, June 02, 2011 6:24 PM
To: Jihoon Kim
Cc: [email protected]
Subject: Re: [E-devel] [PATCH] Add some APIs for supporting virtual keyboard
in Ecore_IMF

On Thu, 02 Jun 2011 18:01:37 +0900 Jihoon Kim <[email protected]>
said:

yes please! :)

> Thanks, raster.
> I missed Changelog patch in ecore.
> I attached the ecore changelog patch.
> Would you please apply in svn?
> 
> -----Original Message-----
> From: Carsten Haitzler (The Rasterman) [mailto:[email protected]] 
> Sent: Thursday, June 02, 2011 4:58 PM
> To: Jihoon Kim
> Cc: [email protected]
> Subject: Re: [E-devel] [PATCH] Add some APIs for supporting virtual
keyboard
> in Ecore_IMF
> 
> On Mon, 30 May 2011 22:14:27 +0900 Jihoon Kim <[email protected]>
> said:
> 
> approved! looks good! well done! thanks!. in svn it is.
> 
> > Hi, EFL developers.
> > 
> > For supporting virtual keyboard, I'd like to add some APIs.
> > The detail description of each API is included in the patch file as
> doxygen
> > format.
> > 
> > In the attached patch, the reason why we add the subprefix
'input_panel_'
> > related to virtual keyboard is 
> > that input method can be soft keyboard or voice input or image captured
by
> > camera.
> > 
> > Would you please review this patch?
> > 
> 
> 
> -- 
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler)    [email protected]


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    [email protected]

Index: src/lib/ecore_imf/ecore_imf_context.c
===================================================================
--- src/lib/ecore_imf/ecore_imf_context.c       (revision 61106)
+++ src/lib/ecore_imf/ecore_imf_context.c       (working copy)
@@ -1055,6 +1055,96 @@ ecore_imf_context_control_panel_hide (Ecore_IMF_Co
 }
 
 /**
+ * Ask the Input Method Context to show the input panel (virtual keyboard).
+ *
+ * @param ctx An #Ecore_IMF_Context.
+ * @ingroup Ecore_IMF_Context_IMControl_Group
+ * @since 1.1.0
+ */
+EAPI void
+ecore_imf_context_input_panel_show(Ecore_IMF_Context *ctx)
+{
+   if (!ECORE_MAGIC_CHECK(ctx, ECORE_MAGIC_CONTEXT))
+     {
+        ECORE_MAGIC_FAIL(ctx, ECORE_MAGIC_CONTEXT,
+                         "ecore_imf_context_input_panel_show");
+        return;
+     }
+
+   if (ctx->klass->show) ctx->klass->show(ctx);
+}
+
+/**
+ * Ask the Input Method Context to hide the input panel.
+ *
+ * @param ctx An #Ecore_IMF_Context.
+ * @ingroup Ecore_IMF_Context_IMControl_Group
+ * @since 1.1.0
+ */
+EAPI void
+ecore_imf_context_input_panel_hide(Ecore_IMF_Context *ctx)
+{
+   if (!ECORE_MAGIC_CHECK(ctx, ECORE_MAGIC_CONTEXT))
+     {
+        ECORE_MAGIC_FAIL(ctx, ECORE_MAGIC_CONTEXT,
+                         "ecore_imf_context_input_panel_hide");
+        return;
+     }
+
+   if (ctx->klass->hide) ctx->klass->hide(ctx);
+}
+
+/**
+ * Set the layout of the input panel.
+ *
+ * @param ctx An #Ecore_IMF_Context.
+ * @param layout see #ECORE_IMF_INPUT_PANEL_LAYOUT
+ * @ingroup Ecore_IMF_Context_IMControl_Group
+ * @since 1.1.0
+ */
+EAPI void
+ecore_imf_context_input_panel_layout_set (Ecore_IMF_Context *ctx, 
Ecore_IMF_Input_Panel_Layout layout)
+{
+   if (!ECORE_MAGIC_CHECK(ctx, ECORE_MAGIC_CONTEXT))
+     {
+        ECORE_MAGIC_FAIL(ctx, ECORE_MAGIC_CONTEXT,
+                         "ecore_imf_context_input_panel_layout_set");
+        return;
+     }
+
+   if (ctx->klass->input_panel_layout_set)
+     ctx->klass->input_panel_layout_set(ctx, layout);
+
+   ctx->input_panel_layout = layout;
+}
+
+/**
+ * Get the layout of the current active input panel.
+ *
+ * @param ctx An #Ecore_IMF_Context.
+ * @return layout see #Ecore_IMF_Input_Panel_Layout
+ * @ingroup Ecore_IMF_Context_IMControl_Group
+ * @since 1.1.0
+ */
+EAPI Ecore_IMF_Input_Panel_Layout
+ecore_imf_context_input_panel_layout_get (Ecore_IMF_Context *ctx)
+{
+   if (!ECORE_MAGIC_CHECK(ctx, ECORE_MAGIC_CONTEXT))
+     {
+        ECORE_MAGIC_FAIL(ctx, ECORE_MAGIC_CONTEXT,
+                         "ecore_imf_context_input_panel_layout_get");
+        return ECORE_IMF_INPUT_PANEL_LAYOUT_INVALID;
+     }
+
+   if (ctx->klass->input_panel_layout_get)
+     {
+        return ctx->input_panel_layout;
+     }
+   else
+     return ECORE_IMF_INPUT_PANEL_LAYOUT_INVALID;
+}
+
+/**
  * Set the language of the input panel.
  * This API can be used when you want to show the English keyboard.
  *

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to