On Thu, 07 Jul 2011 03:45:47 +0900 jy0703.p...@samsung.com said: some minor comments on the src:
1. snprintf... + snprintf(frame_index_char, 4, "%i",frame_index); should use sizeof - so if buf changes size then the code doesnt need adapting: + snprintf(frame_index_char, sizeof(rame_index_char), "%i", frame_index); 2. Evas_Image_Animated_Loop_Hint probably is best using EVAS_IMAGE_ANIMATED_HINT_LOOP instead of EVAS_IMAGE_ANIMATED_HINT_SEQUENTIAL and EVAS_IMAGE_ANIMATED_HINT_PINGPONG instead of EVAS_IMAGE_ANIMATED_HINT_REVERSE. 3. DOCUMENTATION for the new api calls! we need full documentation in Evas.h like the other evas calls!!!! with examples of usage etc. 4. you need to fix up the gl_x11 engine too. :) 5. evas_image_get_frame_duration_gif seems out of place name-wise. use: evas_image_load_frame_duration_gif 6. not handling 0 duration frames. i am not sure on the animated gif standrads, but gif animations with 0 frametime seems to run at 10fps or something (default). so best to return that value. check the specs though. 7. this doesn't handle some of the most common animated gif modes - the disposal mode most commonly used is to draw on top of the previous frame and even with offset values etc. :) > Hi. I'm Jiyoun. > > I made patch related with animated evas object image. > > <evas\src\lib\Evas.h> > EAPI Eina_Bool evas_object_image_animated_get(const Evas_Object *obj); > EAPI int evas_object_image_animated_frame_num_get(const Evas_Object *obj); > EAPI Evas_Image_Animated_Loop_Hint > evas_object_image_animated_loop_type_get(const Evas_Object *obj); > EAPI int evas_object_image_animated_loop_count_get(const Evas_Object *obj); > EAPI double evas_object_image_animated_frame_duration_get(const Evas_Object > *obj, int start_frame, int fram_num); //return time duration > EAPI void evas_object_image_animated_frame_set(Evas_Object *obj, int > frame_num); > > <evas\src\lib\engines\common\evas_image.h> > EAPI double evas_common_get_rgba_image_frame_duration_from_file(Image_Entry > *im, int start_frame, int frame_num); > > > I attached test code. > > <Todo list> > 1. Modify evas_object_image_animated_frame_set > -currently I just use key for frame, but for performance and other issue, > I have to modify this and make cache system or other > 2. make new cash system or hash table for store short cut for gif random > access > 3. support other animation file type > 4. documentation and test case code > 5. etc. (bug or other problems I cannot find yet) > > And there are so many things to do related with animated image object. > I have plan to improve animated image object more and more . > If there is some problem in source or test code, please let me know it. > > Thanks. > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
