On 07/16/11 08:52, Tom Hacohen wrote: > On 16/07/11 01:00, Christopher Michael wrote: >> Please, for the love of all things sacred& holy, do NOT run that on the new >> ecore code !!! It makes it very hard to read& change the code ;) >> >> Dh >> >> >> Sent from my iPod >> >> On Jul 15, 2011, at 3:26 PM, "Enlightenment SVN"<no-re...@enlightenment.org> >> wrote: >> >>> Log: >>> ecrustified because it was terrible >>> >>> >>> Author: discomfitor >>> Date: 2011-07-15 12:26:57 -0700 (Fri, 15 Jul 2011) >>> New Revision: 61414 >>> Trac: http://trac.enlightenment.org/e/changeset/61414 >>> >>> Modified: >>> trunk/e/src/modules/mixer/sys_alsa.c >>> >>> Modified: trunk/e/src/modules/mixer/sys_alsa.c >>> =================================================================== >>> --- trunk/e/src/modules/mixer/sys_alsa.c 2011-07-15 18:37:44 UTC (rev >>> 61413) >>> +++ trunk/e/src/modules/mixer/sys_alsa.c 2011-07-15 19:26:57 UTC (rev >>> 61414) >>> @@ -5,18 +5,20 @@ >>> >>> struct e_mixer_callback_desc >>> { >>> - int (*func)(void *data, E_Mixer_System *self); >>> - void *data; >>> + int (*func)(void *data, >>> + E_Mixer_System *self); >>> + void *data; >>> E_Mixer_System *self; >>> - Ecore_Idler *idler; >>> - Eina_List *handlers; >>> + Ecore_Idler *idler; >>> + Eina_List *handlers; >>> }; >>> >>> +static int _mixer_callback_add(E_Mixer_System *self, >>> + int (*func)(void *data, E_Mixer_System >>> *self), >>> + void *data); >>> +static int _mixer_callback_del(E_Mixer_System *self, >>> + struct e_mixer_callback_desc *desc); >>> >>> -static int _mixer_callback_add(E_Mixer_System *self, int (*func)(void >>> *data, E_Mixer_System *self), void *data); >>> -static int _mixer_callback_del(E_Mixer_System *self, struct >>> e_mixer_callback_desc *desc); >> > > Joking aside, the static function decelerations are awfully indented, > really, it's terribly ugly. > > -- > Tom. > Indeed they are. That's just one of the reasons that I asked for crustify to NOT be run on the new code. Makes it terrible to try to read and work on ;)
dh ------------------------------------------------------------------------------ AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
