On 08/01/2011 07:23 PM, Christopher Michael wrote: > On 08/01/2011 05:02 PM, Boris Faure wrote: >> On Mon, Aug 1, 2011 at 21:59, Christopher Michael >> <cpmicha...@comcast.net> wrote: >>>> On Mon, Aug 1, 2011 at 5:01 AM, Boris Faure<bill...@gmail.com> wrote: >>>>> I'll rewrite the patch to make ecore_xcb work with both xcb< 1.7 and >>>>> xcb>= 1.7 so that it's fine for everyone. >>> >>> New patch sounds good :) as long as it will build for both .. until such >>> time that distros across the spectrum are all updated to development >>> xcb. When that happens then we can stop supporting current stable xcb >>> (0.3.6) and remove the legacy code :) >>> >>> When you get your new patch(s) ready, send them out to the mailing list >>> and I'll gladly have a look :) >> >> Patch is attached. Tell me if it works fine for you and I'll gladly >> commit it. >> I've done a few things other than just use the new API: >> - removed an unused var in ecore_x_icccm_size_pos_hints_get() and >> added __UNUSED__ on win, >> - changed LONG_MAX into UINT32_MAX in ecore_x_window_prop_property_get(). >> I think UINT32_MAX should be used instead of hard-coding 0x7fffffff or >> 1000000L when calling xcb_get_property_unchecked(). >> > Ok, that is not correct. 'Win' is used there: > > xcb_get_wm_normal_hints_unchecked(conn, win); > > I am seeing some other issues with this patch also, but it is a good > start. I'll use this patch, fix some incorrect things and apply. > > Thanks, > dh > Yea, I cannot accept this patch as it sits currently. It will not even apply against current ecore from svn :( so I will have to manually cherry pick it.
dh ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
