On 08/08/2011 04:42 PM, Vincent Torri wrote: > > > On Mon, 8 Aug 2011, Enlightenment SVN wrote: > >> Log: >> Ecore_X: Remove check for damage extension version. (we don't check >> version in xlib, so don't check it here). > > and you're sure that xlib code is bug free ? > > Vincent > LMAO !! :)
Heck no (and that's the discussion I had w/ Tom) :) BUT I am trying to track down an issue w/ xcb stuff so I need it to match xlib as much as possible (for now). If/When we find out that the version check is really needed (which I doubt), then we can easily re-enable it. It's not a big deal at the moment because nobody is really using the xcb stuff right now, so no harm done. dh >> >> >> >> Author: devilhorns >> Date: 2011-08-08 12:15:04 -0700 (Mon, 08 Aug 2011) >> New Revision: 62212 >> Trac: http://trac.enlightenment.org/e/changeset/62212 >> >> Modified: >> trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c >> >> Modified: trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c >> =================================================================== >> --- trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c 2011-08-08 >> 18:59:25 UTC (rev 62211) >> +++ trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c 2011-08-08 >> 19:15:04 UTC (rev 62212) >> @@ -42,8 +42,7 @@ >> reply = xcb_damage_query_version_reply(_ecore_xcb_conn, cookie, >> NULL); >> if (reply) >> { >> - if (reply->major_version>= XCB_DAMAGE_MAJOR_VERSION) >> - _damage_avail = EINA_TRUE; >> + _damage_avail = EINA_TRUE; >> free(reply); >> } >> >> ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
