On Mon, Aug 22, 2011 at 12:11 PM, Brian 'morlenxus' Miculcy <morlen...@gmx.net> wrote: > I don't like it, and i don't think it's an improvement: > ... > I don't like how you just commit your stuff, not taking care of other > peoples code. You commit and write something about "open for critique", > but i think you should first ask people before you change everything > just as you like. Start a discussion on ml, e.g. common things. > > Same with the efm_nav module. It allowed the user to enter a path in the > efm toolbar with the keyboard. You removed the module from svn, i told > you that it worked and that users might want it, but you didn't care and > didn't restore. > > This is not my idea of working in a team on a project. If i follow your > way, i would just commit the old menu code and overwrite your changes. >
The common way to work here as I understood is to commit changes when you think you made an improvement (one should ask the manager of a module before first time commiting to a module though) When somebody does not like the change it will be discussed or manager for that module can revert. > Please revert. > > Brian 'morlenxus' Miculcy > > ------------------------------------------------------------------------------ uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
