This looks cool! So is it encouraged to use elm_app_xxx APIs? Daniel Juyung Seo (SeoZ)
On Thu, Aug 25, 2011 at 6:59 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Thu, 25 Aug 2011 10:50:36 +0200 Jérémy Zurcher <jer...@asynk.ch> said: > hmm... elm_app_compile_data_dir_set(PACKAGE_DATA_DIR); shouldnt be removed in > your patch - this is done so the elm app finding process can find the > compile-time path IF runtime detection fails. it in fact USES this path to > figure out the desired location. > > your eina_preifx patch does make it more robust - but those pkg_bin_dir were > not intended to be optional and NULL. they were hard requirements. i guess we > can be more gentle on them being null - but you really want to set the > compiletime package data dir and bin dir... really want to! i changed that in > your patch - also fixed warnings your patch in eina created. > >> Hi, >> >> please find attached a small patch for eina_prefix >> >> it prevent segfault when for instance >> no elm_app_compile_*_dir_set is called prior to elm_app_info_set >> >> and another one for elementary/src/bin/test*.c which tends to replace >> usage of PACKAGE_DATA_DIR with elm_app_data_dir_get >> >> Jérémy >> >> >> !DSPAM:4e560c473404098512160! > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > EMC VNX: the world's simplest storage, starting under $10K > The only unified storage solution that offers unified management > Up to 160% more powerful than alternatives and 25% more efficient. > Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
