On Thursday, September 15, 2011, Cedric BAIL <cedric.b...@free.fr> wrote: > On Thu, Sep 15, 2011 at 3:07 PM, Gustavo Sverzut Barbieri > <barbi...@profusion.mobi> wrote: >> Use safety checks for null/invalid parameters > > Yep, will do. Forgot about that macro. > >> Container get should return ls path, no? AFAIR other iterators do it. > > I didn't know, so why not the path. > >> How about the helper to set/get string, float and interger values? They can >> convert to string or just store using some standard binary representation >> that is platform independent. > > I was planning to put this helper in eio only. Do you think they > should be in eina instead ?
On both. Particularly for read i see most people using only eina > >> On Thursday, September 15, 2011, Enlightenment SVN < >> no-re...@enlightenment.org> wrote: >>> Log: >>> eina: add XAttr support to eina. >>> >>> >>> Author: cedric >>> Date: 2011-09-15 05:39:40 -0700 (Thu, 15 Sep 2011) >>> New Revision: 63408 >>> Trac: http://trac.enlightenment.org/e/changeset/63408 >>> >>> Modified: >>> trunk/eina/configure.ac trunk/eina/src/include/eina_file.h >> trunk/eina/src/lib/eina_file.c >>> >>> Modified: trunk/eina/configure.ac >>> =================================================================== >>> --- trunk/eina/configure.ac 2011-09-15 11:15:46 UTC (rev 63407) >>> +++ trunk/eina/configure.ac 2011-09-15 12:39:40 UTC (rev 63408) >>> @@ -621,6 +621,29 @@ >>> >>> AC_SUBST([rt_libs]) >>> >>> +### Check for extended attribute >>> + >>> +AC_COMPILE_IFELSE( >>> + [AC_LANG_PROGRAM( >>> + [[ >>> +#include <stdlib.h> >>> +#include <sys/types.h> >>> +#include <sys/xattr.h> >>> + ]], >>> + [[ >>> +size_t tmp = listxattr("/", NULL, 0); >>> +tmp = getxattr("/", "user.ethumb.md5", NULL, 0); >>> +setxattr("/", "user.ethumb.md5", NULL, 0, 0); >>> + ]])], >>> + [ >>> + AC_DEFINE(HAVE_XATTR, 1, [Define to 1 if you have 'listxattr', >> 'setxattr' and 'getxattr']) >>> + have_xattr="yes" >>> + ], >>> + [have_xattr="no"]) >>> + >>> +AC_MSG_CHECKING([for Xattr]) >>> +AC_MSG_RESULT([${have_xattr}]) >>> + >>> ### Modules >>> >>> if test "x${have_default_mempool}" = "xyes" ; then >>> @@ -736,6 +759,7 @@ >>> echo " Amalgamation.........: ${do_amalgamation}" >>> echo " Iconv support........: ${have_iconv}" >>> echo " File dirfd...........: ${have_dirfd}" >>> +echo " File xattr...........: ${have_xattr}" >>> echo >>> echo " Documentation........: ${build_doc}" >>> echo " Tests................: ${enable_tests}" >>> >>> Modified: trunk/eina/src/include/eina_file.h >>> =================================================================== >>> --- trunk/eina/src/include/eina_file.h 2011-09-15 11:15:46 UTC (rev >> 63407) >>> +++ trunk/eina/src/include/eina_file.h 2011-09-15 12:39:40 UTC (rev >> 63408) >>> @@ -112,6 +112,12 @@ >>> EINA_FILE_WHT /**< Whiteout file type (unused on Windows). */ >>> } Eina_File_Type; >>> >>> +typedef enum { >>> + EINA_XATTR_INSERT, /**< This is the default behaviour, it will either >> create or replace the extended attribute */ >>> + EINA_XATTR_REPLACE, /**< This will only succeed if the extended >> attribute previously existed */ >>> + EINA_XATTR_CREATED /**< This will only succeed if the extended >> attribute wasn't previously set */ >>> +} Eina_Xattr_Flags; >>> + >>> typedef struct _Eina_File Eina_File; >>> >>> typedef enum { >>> @@ -274,6 +280,47 @@ >>> EAPI Eina_Iterator *eina_file_direct_ls(const char *dir) >> EINA_WARN_UNUSED_RESULT EINA_ARG_NONNULL(1) EINA_MALLOC; >>> >>> /** >>> + * @brief Get an iterator that list all extended attribute of a file. >>> + * >>> + * @param file The filename to retrieve the extended attribute list from. >>> + * @return an iterator. >>> + * >>> + * The iterator will not allocate any data during the iteration step, so >> you need to cop> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> > > > > -- > Cedric BAIL > > ------------------------------------------------------------------------------ > Doing More with Less: The Next Generation Virtual Desktop > What are the key obstacles that have prevented many mid-market businesses > from deploying virtual desktops? How do next-generation virtual desktops > provide companies an easier-to-deploy, easier-to-manage and more affordable > virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Doing More with Less: The Next Generation Virtual Desktop What are the key obstacles that have prevented many mid-market businesses from deploying virtual desktops? How do next-generation virtual desktops provide companies an easier-to-deploy, easier-to-manage and more affordable virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel