On Thu, 6 Oct 2011 20:33:40 +0900 cnook <[email protected]> said: > Dear All, Hi! > > If the ctxpopup is vertical mode and it has too long text item to display, > then the text item is not compressed and the ctxpopup has vertical > scrollbar, horizontal scrollbar both. > User can scroll both sides and diagonally(?) also. > So, the attached patch will compress text item, when the text item is > too long to display. > Please review this patch and give any feedback. Thanks.
aha! review time. feedback: you don't handle going OUT of compress mode, only in (ie you only ever enable compress in sizing_eval, never disable. api calls specifically disable even though they could maybe be called after ctxpopup has already gone into compress mode because of sizing reasons). you don't reset the elm theme (edje object) for the items when they go out of compress mode like you do going in in _compress_item().. and you call that every time you do a sizing eval even if you are ALREADY in compress mode. also make sure you have if ( not if( (space between if and (). can you fix these and re-submit? thanks! :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
